The schema doesn't allow for a single (unaddressed) ethernet port node
nor does a single port switch make much sense. So if there's always
multiple child nodes, "#address-cells" and "#size-cells" should be
required.
Signed-off-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/net/ethernet-switch.yaml | 4 ++++
Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml | 4 +++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/ethernet-switch.yaml b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
index a04f8ef744aa..2ceccce6cbd7 100644
--- a/Documentation/devicetree/bindings/net/ethernet-switch.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
@@ -40,6 +40,10 @@ patternProperties:
type: object
description: Ethernet switch ports
+ required:
+ - "#address-cells"
+ - "#size-cells"
+
oneOf:
- required:
- ports
diff --git a/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
index d7748dd33199..ad1ff9533697 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
@@ -53,7 +53,9 @@ examples:
reg = <0x10>;
ports {
- /* ... */
+ #address-cells = <1>;
+ #size-cells = <0>;
+ /* ... */
};
};
};
--
2.39.2
On Tue, Apr 04, 2023 at 03:42:13PM -0500, Rob Herring wrote:
> The schema doesn't allow for a single (unaddressed) ethernet port node
> nor does a single port switch make much sense. So if there's always
> multiple child nodes, "#address-cells" and "#size-cells" should be
> required.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
Reviewed-by: Vladimir Oltean <[email protected]>
On 4/4/2023 1:42 PM, Rob Herring wrote:
> The schema doesn't allow for a single (unaddressed) ethernet port node
> nor does a single port switch make much sense. So if there's always
> multiple child nodes, "#address-cells" and "#size-cells" should be
> required.
>
> Signed-off-by: Rob Herring <[email protected]>
Reviewed-by: Florian Fainelli <[email protected]>
--
Florian
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:
On Tue, 4 Apr 2023 15:42:13 -0500 you wrote:
> The schema doesn't allow for a single (unaddressed) ethernet port node
> nor does a single port switch make much sense. So if there's always
> multiple child nodes, "#address-cells" and "#size-cells" should be
> required.
>
> Signed-off-by: Rob Herring <[email protected]>
>
> [...]
Here is the summary with links:
- dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required
https://git.kernel.org/netdev/net-next/c/c8f1f2e94675
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html