2023-04-23 14:49:47

by Jiaxun Yang

Subject: [PATCH] MIPS: Remove unused variable in arch_local_irq_restore

It was left over in 9efe1ad6f24a ("MIPS: Don't play with fire in
DIEI irq_restore").

Signed-off-by: Jiaxun Yang <[email protected]>
---
arch/mips/include/asm/irqflags.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/mips/include/asm/irqflags.h b/arch/mips/include/asm/irqflags.h
index 3357bce75c69..b79269789c71 100644
--- a/arch/mips/include/asm/irqflags.h
+++ b/arch/mips/include/asm/irqflags.h
@@ -59,8 +59,6 @@ static inline unsigned long arch_local_irq_save(void)

static inline void arch_local_irq_restore(unsigned long flags)
{
- unsigned long __tmp1;
-
if (likely(flags)) {
__asm__ __volatile__(
" .set push \n"
--
2.39.2 (Apple Git-143)

2023-04-23 14:50:06

by Jiaxun Yang

Subject: Re: [PATCH] MIPS: Remove unused variable in arch_local_irq_restore

> 2023年4月23日 15:35，Jiaxun Yang <[email protected]> 写道：
>
> It was left over in 9efe1ad6f24a ("MIPS: Don't play with fire in
> DIEI irq_restore").
>
> Signed-off-by: Jiaxun Yang <[email protected]>

Oh sorry please ignore the noise.

mips-fixes tree on codeaurora mirror is lapsed. Really shouldn’t use that mirror.

Thanks
Jiaxun

> ---
> arch/mips/include/asm/irqflags.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/include/asm/irqflags.h b/arch/mips/include/asm/irqflags.h
> index 3357bce75c69..b79269789c71 100644
> --- a/arch/mips/include/asm/irqflags.h
> +++ b/arch/mips/include/asm/irqflags.h
> @@ -59,8 +59,6 @@ static inline unsigned long arch_local_irq_save(void)
>
> static inline void arch_local_irq_restore(unsigned long flags)
> {
> - unsigned long __tmp1;
> -
> if (likely(flags)) {
> __asm__ __volatile__(
> " .set push \n"
> --
> 2.39.2 (Apple Git-143)
>

2023-04-23 15:41:15

by Jiaxun Yang

Subject: Re: [PATCH] MIPS: Remove unused variable in arch_local_irq_restore

> 2023年4月23日 15:42，Jiaxun Yang <[email protected]> 写道：
>
>
>
>> 2023年4月23日 15:35，Jiaxun Yang <[email protected]> 写道：
>>
>> It was left over in 9efe1ad6f24a ("MIPS: Don't play with fire in
>> DIEI irq_restore").
>>
>> Signed-off-by: Jiaxun Yang <[email protected]>
>
> Oh sorry please ignore the noise.
>
> mips-fixes tree on codeaurora mirror is lapsed. Really shouldn’t use that mirror.

Reported to korg helpdesk, hopefully they can get it fixed :-)

That’s the only option for my remote development machine located in China.

Thanks
Jiaxun