The panel-common schema does not define what "ports" property is, so
bring the definition to enforce the type. Panels can be single- or
dual-link, thus require only one port@0.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. Rework to add ports to device schema, not to panel-common.
https://lore.kernel.org/all/[email protected]/
---
.../bindings/display/panel/novatek,nt35950.yaml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
index 377a05d48a02..c93cc1018b41 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
@@ -47,8 +47,13 @@ properties:
vddio-supply:
description: regulator that supplies the I/O voltage
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ required:
+ - port@0
+
backlight: true
- ports: true
reg: true
required:
@@ -59,6 +64,7 @@ required:
- avee-supply
- dvdd-supply
- vddio-supply
+ - ports
additionalProperties: false
--
2.34.1
The panel-common schema does not define what "ports" property is, so
bring the definition to enforce the type. All panels described by
binding are dual-link, thus require both ports.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. Rework to add ports to device schema, not to panel-common.
https://lore.kernel.org/all/[email protected]/
---
.../bindings/display/panel/novatek,nt36523.yaml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
index 0039561ef04c..a2a8c4e39573 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
@@ -32,8 +32,14 @@ properties:
vddio-supply:
description: regulator that supplies the I/O voltage
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ required:
+ - port@0
+ - port@1
+
reg: true
- ports: true
backlight: true
required:
--
2.34.1
On Tue, May 02, 2023 at 02:00:36PM +0200, Krzysztof Kozlowski wrote:
> description: regulator that supplies the I/O voltage
[..]
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + required:
> + - port@0
> + - port@1
Konrad has added a single DSI panel to this bindings, so we should
drop port@1 to allow it.
See https://lore.kernel.org/lkml/[email protected]/
> +
> reg: true
> - ports: true
> backlight: true
>
> required:
> --
> 2.34.1
>
On 02/05/2023 14:44, Jianhua Lu wrote:
> On Tue, May 02, 2023 at 02:00:36PM +0200, Krzysztof Kozlowski wrote:
>> description: regulator that supplies the I/O voltage
> [..]
>>
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + required:
>> + - port@0
>> + - port@1
> Konrad has added a single DSI panel to this bindings, so we should
> drop port@1 to allow it.
>
> See https://lore.kernel.org/lkml/[email protected]/
Thanks, I'll send a v2 ~tomorrow.
Best regards,
Krzysztof
On Tue, May 02, 2023 at 02:00:36PM +0200, Krzysztof Kozlowski wrote:
> The panel-common schema does not define what "ports" property is, so
> bring the definition to enforce the type. All panels described by
> binding are dual-link, thus require both ports.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. Rework to add ports to device schema, not to panel-common.
> https://lore.kernel.org/all/[email protected]/
> ---
> .../bindings/display/panel/novatek,nt36523.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> index 0039561ef04c..a2a8c4e39573 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> @@ -32,8 +32,14 @@ properties:
> vddio-supply:
> description: regulator that supplies the I/O voltage
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + required:
> + - port@0
> + - port@1
What is each port?
You need:
additionalProperties: false
properties:
port@0:
$ref: ...
description: ...
port@1:
$ref: ...
description: ...
On Tue, May 02, 2023 at 02:00:35PM +0200, Krzysztof Kozlowski wrote:
> The panel-common schema does not define what "ports" property is, so
> bring the definition to enforce the type. Panels can be single- or
> dual-link, thus require only one port@0.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. Rework to add ports to device schema, not to panel-common.
> https://lore.kernel.org/all/[email protected]/
> ---
> .../bindings/display/panel/novatek,nt35950.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
> index 377a05d48a02..c93cc1018b41 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35950.yaml
> @@ -47,8 +47,13 @@ properties:
> vddio-supply:
> description: regulator that supplies the I/O voltage
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
Similarly needed on this one.
Perhaps what you want here is a dual-link panel schema?
> +
> + required:
> + - port@0
> +
> backlight: true
> - ports: true
> reg: true
>
> required:
> @@ -59,6 +64,7 @@ required:
> - avee-supply
> - dvdd-supply
> - vddio-supply
> + - ports
>
> additionalProperties: false
>
> --
> 2.34.1
>