2023-05-06 23:31:06

by Maksim Kiselev

[permalink] [raw]
Subject: [PATCH v3 4/5] spi: sun6i: add support for R329/D1/R528/T113s SPI controllers

These SoCs has two SPI controllers. One of it is quite similar to previous
ones, but with internal clock divider removed; the other added MIPI DBI
Type-C offload based on the first one.

Add basical support for these controllers. As we're not going to
support the DBI functionality now, just implement the two kinds of
controllers as the same.

Co-developed-by: Icenowy Zheng <[email protected]>
Signed-off-by: Maksim Kiselev <[email protected]>
---
drivers/spi/spi-sun6i.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
index 1e9e9a8159d9..292fd6101283 100644
--- a/drivers/spi/spi-sun6i.c
+++ b/drivers/spi/spi-sun6i.c
@@ -739,9 +739,17 @@ static const struct sun6i_spi_cfg sun8i_h3_spi_cfg = {
.has_clk_ctl = true,
};

+static const struct sun6i_spi_cfg sun50i_r329_spi_cfg = {
+ .fifo_depth = SUN8I_FIFO_DEPTH,
+};
+
static const struct of_device_id sun6i_spi_match[] = {
{ .compatible = "allwinner,sun6i-a31-spi", .data = &sun6i_a31_spi_cfg },
{ .compatible = "allwinner,sun8i-h3-spi", .data = &sun8i_h3_spi_cfg },
+ {
+ .compatible = "allwinner,sun50i-r329-spi",
+ .data = &sun50i_r329_spi_cfg
+ },
{}
};
MODULE_DEVICE_TABLE(of, sun6i_spi_match);
--
2.39.2


2023-05-07 11:00:11

by Andre Przywara

[permalink] [raw]
Subject: Re: [PATCH v3 4/5] spi: sun6i: add support for R329/D1/R528/T113s SPI controllers

On Sun, 7 May 2023 02:26:07 +0300
Maksim Kiselev <[email protected]> wrote:

> These SoCs has two SPI controllers. One of it is quite similar to previous
> ones, but with internal clock divider removed; the other added MIPI DBI
> Type-C offload based on the first one.
>
> Add basical support for these controllers. As we're not going to
> support the DBI functionality now, just implement the two kinds of
> controllers as the same.
>
> Co-developed-by: Icenowy Zheng <[email protected]>
> Signed-off-by: Maksim Kiselev <[email protected]>

Reviewed-by: Andre Przywara <[email protected]>

Cheers,
Andre

> ---
> drivers/spi/spi-sun6i.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
> index 1e9e9a8159d9..292fd6101283 100644
> --- a/drivers/spi/spi-sun6i.c
> +++ b/drivers/spi/spi-sun6i.c
> @@ -739,9 +739,17 @@ static const struct sun6i_spi_cfg sun8i_h3_spi_cfg = {
> .has_clk_ctl = true,
> };
>
> +static const struct sun6i_spi_cfg sun50i_r329_spi_cfg = {
> + .fifo_depth = SUN8I_FIFO_DEPTH,
> +};
> +
> static const struct of_device_id sun6i_spi_match[] = {
> { .compatible = "allwinner,sun6i-a31-spi", .data = &sun6i_a31_spi_cfg },
> { .compatible = "allwinner,sun8i-h3-spi", .data = &sun8i_h3_spi_cfg },
> + {
> + .compatible = "allwinner,sun50i-r329-spi",
> + .data = &sun50i_r329_spi_cfg
> + },
> {}
> };
> MODULE_DEVICE_TABLE(of, sun6i_spi_match);