2023-06-09 08:30:13

by Maxime Chevallier

[permalink] [raw]
Subject: [PATCH net v2 0/2] fixes for Q-USGMII speeds and autoneg

This is the second version of a small changeset for QUSGMII support,
fixing inconsistencies in reported max speed and control word parsing.

As reported here [1], there are some inconsistencies for the Q-USGMII
mode speeds and configuration. The first patch in this fixup series
makes so that we correctly report the max speed of 1Gbps for this mode.

The second patch uses a dedicated helper to decode the control word.
This is necessary as although USGMII control words are close to USXGMII,
they don't support the same speeds.

Thanks,

Maxime

[1] : https://lore.kernel.org/netdev/[email protected]/

V1->V2: Fix decoding logic for usgmii control word, as per Russell's review

Maxime Chevallier (2):
net: phylink: report correct max speed for QUSGMII
net: phylink: use a dedicated helper to parse usgmii control word

drivers/net/phy/phylink.c | 41 +++++++++++++++++++++++++++++++++++++--
1 file changed, 39 insertions(+), 2 deletions(-)

--
2.40.1



2023-06-09 08:33:19

by Russell King (Oracle)

[permalink] [raw]
Subject: Re: [PATCH net v2 0/2] fixes for Q-USGMII speeds and autoneg

On Fri, Jun 09, 2023 at 10:03:03AM +0200, Maxime Chevallier wrote:
> This is the second version of a small changeset for QUSGMII support,
> fixing inconsistencies in reported max speed and control word parsing.
>
> As reported here [1], there are some inconsistencies for the Q-USGMII
> mode speeds and configuration. The first patch in this fixup series
> makes so that we correctly report the max speed of 1Gbps for this mode.
>
> The second patch uses a dedicated helper to decode the control word.
> This is necessary as although USGMII control words are close to USXGMII,
> they don't support the same speeds.
>
> Thanks,
>
> Maxime
>
> [1] : https://lore.kernel.org/netdev/[email protected]/
>
> V1->V2: Fix decoding logic for usgmii control word, as per Russell's review

Reviewed-by: Russell King (Oracle) <[email protected]>

Thanks!

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

2023-06-13 00:13:16

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net v2 0/2] fixes for Q-USGMII speeds and autoneg

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

On Fri, 9 Jun 2023 10:03:03 +0200 you wrote:
> This is the second version of a small changeset for QUSGMII support,
> fixing inconsistencies in reported max speed and control word parsing.
>
> As reported here [1], there are some inconsistencies for the Q-USGMII
> mode speeds and configuration. The first patch in this fixup series
> makes so that we correctly report the max speed of 1Gbps for this mode.
>
> [...]

Here is the summary with links:
- [net,v2,1/2] net: phylink: report correct max speed for QUSGMII
https://git.kernel.org/netdev/net/c/b9dc1046edfe
- [net,v2,2/2] net: phylink: use a dedicated helper to parse usgmii control word
https://git.kernel.org/netdev/net/c/923454c0368b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html