From: Maxim Kiselev <[email protected]>
Add a binding for D1/T113s thermal sensor controller.
Signed-off-by: Maxim Kiselev <[email protected]>
---
.../thermal/allwinner,sun8i-a83t-ths.yaml | 20 ++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
index fbd4212285e2..001faa37fc27 100644
--- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
+++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
@@ -16,6 +16,7 @@ properties:
- allwinner,sun8i-a83t-ths
- allwinner,sun8i-h3-ths
- allwinner,sun8i-r40-ths
+ - allwinner,sun20i-d1-ths
- allwinner,sun50i-a64-ths
- allwinner,sun50i-a100-ths
- allwinner,sun50i-h5-ths
@@ -61,6 +62,7 @@ allOf:
compatible:
contains:
enum:
+ - allwinner,sun20i-d1-ths
- allwinner,sun50i-a100-ths
- allwinner,sun50i-h6-ths
@@ -84,7 +86,9 @@ allOf:
properties:
compatible:
contains:
- const: allwinner,sun8i-h3-ths
+ enum:
+ - allwinner,sun8i-h3-ths
+ - allwinner,sun20i-d1-ths
then:
properties:
@@ -103,6 +107,7 @@ allOf:
enum:
- allwinner,sun8i-h3-ths
- allwinner,sun8i-r40-ths
+ - allwinner,sun20i-d1-ths
- allwinner,sun50i-a64-ths
- allwinner,sun50i-a100-ths
- allwinner,sun50i-h5-ths
@@ -159,4 +164,17 @@ examples:
#thermal-sensor-cells = <1>;
};
+ - |
+ thermal-sensor@2009400 {
+ compatible = "allwinner,sun20i-d1-ths";
+ reg = <0x02009400 0x400>;
+ interrupts = <0 90 0>;
+ clocks = <&ccu 0>;
+ clock-names = "bus";
+ resets = <&ccu 2>;
+ nvmem-cells = <&ths_calibration>;
+ nvmem-cell-names = "calibration";
+ #thermal-sensor-cells = <0>;
+ };
+
...
--
2.39.2
On Sat, Jun 10, 2023 at 11:42:18PM +0300, Maksim Kiselev wrote:
> From: Maxim Kiselev <[email protected]>
>
> Add a binding for D1/T113s thermal sensor controller.
>
> Signed-off-by: Maxim Kiselev <[email protected]>
btw, please try not to resubmit patches while there's still some
discussion on the previous version, as things are likely to get
lost/muddled.
One of the downsides of email!
Cheers,
Conor.
On 10/06/2023 22:42, Maksim Kiselev wrote:
> From: Maxim Kiselev <[email protected]>
>
> Add a binding for D1/T113s thermal sensor controller.
>
> Signed-off-by: Maxim Kiselev <[email protected]>
One patchset per day, not multiple within 15 minutes.
> ---
> .../thermal/allwinner,sun8i-a83t-ths.yaml | 20 ++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> index fbd4212285e2..001faa37fc27 100644
> --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> @@ -16,6 +16,7 @@ properties:
> - allwinner,sun8i-a83t-ths
> - allwinner,sun8i-h3-ths
> - allwinner,sun8i-r40-ths
> + - allwinner,sun20i-d1-ths
> - allwinner,sun50i-a64-ths
> - allwinner,sun50i-a100-ths
> - allwinner,sun50i-h5-ths
> @@ -61,6 +62,7 @@ allOf:
> compatible:
> contains:
> enum:
> + - allwinner,sun20i-d1-ths
> - allwinner,sun50i-a100-ths
> - allwinner,sun50i-h6-ths
>
> @@ -84,7 +86,9 @@ allOf:
> properties:
> compatible:
> contains:
> - const: allwinner,sun8i-h3-ths
> + enum:
> + - allwinner,sun8i-h3-ths
> + - allwinner,sun20i-d1-ths
>
> then:
> properties:
> @@ -103,6 +107,7 @@ allOf:
> enum:
> - allwinner,sun8i-h3-ths
> - allwinner,sun8i-r40-ths
> + - allwinner,sun20i-d1-ths
> - allwinner,sun50i-a64-ths
> - allwinner,sun50i-a100-ths
> - allwinner,sun50i-h5-ths
> @@ -159,4 +164,17 @@ examples:
> #thermal-sensor-cells = <1>;
> };
>
> + - |
> + thermal-sensor@2009400 {
> + compatible = "allwinner,sun20i-d1-ths";
New compatible does not warrant new example. It's the same as previous.
Drop it.
Best regards,
Krzysztof
On Sat, Jun 10, 2023 at 11:42:18PM +0300, Maksim Kiselev wrote:
> From: Maxim Kiselev <[email protected]>
>
> Add a binding for D1/T113s thermal sensor controller.
>
> Signed-off-by: Maxim Kiselev <[email protected]>
Since the calibration stuff now makes sense to me (and thanks for that),
Reviewed-by: Conor Dooley <[email protected]>
Cheers,
Conor.