2023-06-15 15:28:02

by Sridharan S N

Subject: [PATCH V2 0/2] Add support for GPIO based leds and buttons on IPQ5332/9574 devices

Add support for wlan-2g led and wps button available on IPQ5332 and
IPQ9574

Sridharan S N (2):
arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons
arm64: dts: qcom: ipq9574: enable GPIO based LEDs

.../boot/dts/qcom/ipq5332-rdp-common.dtsi | 39 +++++++++++++++++++
.../boot/dts/qcom/ipq9574-rdp-common.dtsi | 20 ++++++++++
2 files changed, 59 insertions(+)

--
2.17.1

2023-06-15 15:28:08

by Konrad Dybcio

Subject: Re: [PATCH V2 0/2] Add support for GPIO based leds and buttons on IPQ5332/9574 devices

On 15.06.2023 16:53, Sridharan S N wrote:
> Add support for wlan-2g led and wps button available on IPQ5332 and
> IPQ9574
>
> Sridharan S N (2):
> arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons
> arm64: dts: qcom: ipq9574: enable GPIO based LEDs
You sent a v*3* half an hour ago. There's no signs of [RESEND] or other
explanations and the changelog is gone.

Please now send a v4 after you get reviews on this one (which I assume
is the latest) so as not to confuse the patch workflow tools and explain
each of the previous submissions.

Konrad
>
> .../boot/dts/qcom/ipq5332-rdp-common.dtsi | 39 +++++++++++++++++++
> .../boot/dts/qcom/ipq9574-rdp-common.dtsi | 20 ++++++++++
> 2 files changed, 59 insertions(+)
>

2023-06-15 15:29:00

by Sridharan S N

Subject: [PATCH V2 2/2] arm64: dts: qcom: ipq9574: enable GPIO based LEDs

Add support for wlan-2g LED on GPIO 64.

Signed-off-by: Sridharan S N <[email protected]>
---
Changes in V2:
- Updated commit message

.../boot/dts/qcom/ipq9574-rdp-common.dtsi | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
index fd5326dc1773..25424cecd834 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
@@ -34,6 +34,18 @@
debounce-interval = <60>;
};
};
+
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-0 = <&gpio_leds_default>;
+ pinctrl-names = "default";
+
+ led-0 {
+ gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "phy0tx";
+ default-state = "off";
+ };
+ };
};

&blsp1_spi0 {
@@ -137,6 +149,14 @@
drive-strength = <8>;
bias-pull-up;
};
+
+ gpio_leds_default: gpio-leds-default-state {
+ pins = "gpio64";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
+
};

&xo_board_clk {
--
2.17.1