2023-06-22 10:38:43

by Sui Jingfeng

[permalink] [raw]
Subject: [PATCH] drm/drm_gem.c: Remove surplus else after return

else is not generally useful after return

Signed-off-by: Sui Jingfeng <[email protected]>
---
drivers/gpu/drm/drm_gem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 1a5a2cd0d4ec..c18686f434d4 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -1150,8 +1150,8 @@ int drm_gem_pin(struct drm_gem_object *obj)
{
if (obj->funcs->pin)
return obj->funcs->pin(obj);
- else
- return 0;
+
+ return 0;
}

void drm_gem_unpin(struct drm_gem_object *obj)
--
2.25.1



2023-06-26 08:35:05

by Thomas Zimmermann

[permalink] [raw]
Subject: Re: [PATCH] drm/drm_gem.c: Remove surplus else after return



Am 22.06.23 um 12:18 schrieb Sui Jingfeng:
> else is not generally useful after return
>
> Signed-off-by: Sui Jingfeng <[email protected]>

Reviewed-by: Thomas Zimmermann <[email protected]>

> ---
> drivers/gpu/drm/drm_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 1a5a2cd0d4ec..c18686f434d4 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -1150,8 +1150,8 @@ int drm_gem_pin(struct drm_gem_object *obj)
> {
> if (obj->funcs->pin)
> return obj->funcs->pin(obj);
> - else
> - return 0;
> +
> + return 0;
> }
>
> void drm_gem_unpin(struct drm_gem_object *obj)

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Attachments:
OpenPGP_signature (855.00 B)
OpenPGP digital signature

2023-07-04 18:38:37

by Sui Jingfeng

[permalink] [raw]
Subject: Re: drm/drm_gem.c: Remove surplus else after return

Hi,  Thomas


On 2023/6/22 18:18, Sui Jingfeng wrote:
> else is not generally useful after return
>
> Signed-off-by: Sui Jingfeng <[email protected]>
> Reviewed-by: Thomas Zimmermann <[email protected]>
> ---
> drivers/gpu/drm/drm_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 1a5a2cd0d4ec..c18686f434d4 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -1150,8 +1150,8 @@ int drm_gem_pin(struct drm_gem_object *obj)
> {
> if (obj->funcs->pin)
> return obj->funcs->pin(obj);
> - else
> - return 0;
> +
> + return 0;
> }
>
> void drm_gem_unpin(struct drm_gem_object *obj)


I have merge this patch with the dim tool, by using the following command,


 ./dim push-branch drm-misc-next


Is this looks fine?

I'm so worry about the dim tool now.

I want to make sure if I do the things correctly.


2023-07-04 18:38:53

by Sui Jingfeng

[permalink] [raw]
Subject: Re: drm/drm_gem.c: Remove surplus else after return

Hi,

On 2023/7/5 02:14, Sui Jingfeng wrote:
>
> I have merge this patch with the dim tool, by using the following
> command,


I have merged(pushed) this patch just now to drm-misc-next branch.