2023-07-03 07:34:44

by Naresh Kamboju

Subject: next: perf: 32-bit: bench/sched-seccomp-notify.c:139:24: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'uint64_t'

Following build regressions noticed on Linux next-20230703.

Reported-by: Linux Kernel Functional Testing <[email protected]>

Regressions found on i386:

- build/gcc-11-lkftconfig-perf

Regressions found on arm:

- build/gcc-10-lkftconfig-perf
- build/gcc-11-lkftconfig-perf

Build error:
=======
bench/sched-seccomp-notify.c: In function 'bench_sched_seccomp_notify':
bench/sched-seccomp-notify.c:139:24: error: format '%lu' expects
argument of type 'long unsigned int', but argument 2 has type
'uint64_t' {aka 'long long unsigned int'} [-Werror=format=]
139 | printf("# Executed %lu system calls\n\n",
| ~~^
| |
| long unsigned int
| %llu
140 | loops);
| ~~~~~
| |
| uint64_t {aka long long unsigned int}
cc1: all warnings being treated as errors
make[4]: *** [tools/build/Makefile.build:97:
/home/tuxbuild/.cache/tuxmake/builds/1/build/bench/sched-seccomp-notify.o]
Error 1

Links:
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230703/testrun/18069798/suite/build/test/gcc-10-lkftconfig-perf/history/


--
Linaro LKFT
https://lkft.linaro.org

2023-07-03 20:16:19

by Kees Cook

Subject: Re: next: perf: 32-bit: bench/sched-seccomp-notify.c:139:24: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'uint64_t'

On Mon, Jul 03, 2023 at 12:55:59PM +0530, Naresh Kamboju wrote:
> Following build regressions noticed on Linux next-20230703.
>
> Reported-by: Linux Kernel Functional Testing <[email protected]>
>
> Regressions found on i386:
>
> - build/gcc-11-lkftconfig-perf
>
> Regressions found on arm:
>
> - build/gcc-10-lkftconfig-perf
> - build/gcc-11-lkftconfig-perf
>
> Build error:
> =======
> bench/sched-seccomp-notify.c: In function 'bench_sched_seccomp_notify':
> bench/sched-seccomp-notify.c:139:24: error: format '%lu' expects
> argument of type 'long unsigned int', but argument 2 has type
> 'uint64_t' {aka 'long long unsigned int'} [-Werror=format=]
> 139 | printf("# Executed %lu system calls\n\n",
> | ~~^
> | |
> | long unsigned int
> | %llu
> 140 | loops);
> | ~~~~~
> | |
> | uint64_t {aka long long unsigned int}
> cc1: all warnings being treated as errors
> make[4]: *** [tools/build/Makefile.build:97:
> /home/tuxbuild/.cache/tuxmake/builds/1/build/bench/sched-seccomp-notify.o]
> Error 1

Thanks! I've updated the format string to use "%"PRIu64 now.

-Kees

>
> Links:
> - https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230703/testrun/18069798/suite/build/test/gcc-10-lkftconfig-perf/history/
>
>
> --
> Linaro LKFT
> https://lkft.linaro.org

--
Kees Cook