2023-07-05 08:28:53

by Manivannan Sadhasivam

[permalink] [raw]
Subject: Re: [PATCH v1 1/6] dt-bindings: PCI: qcom: Add sa8775p compatible

On Wed, Jul 05, 2023 at 01:47:06PM +0530, Mrinmay Sarkar wrote:
> Add sa8775p platform to the binding.
>
> Signed-off-by: Mrinmay Sarkar <[email protected]>
> ---
> .../devicetree/bindings/pci/qcom,pcie.yaml | 28 +++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index 81971be4e554..2c79585a2d1e 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -40,6 +40,7 @@ properties:
> - qcom,pcie-sm8450-pcie0
> - qcom,pcie-sm8450-pcie1
> - qcom,pcie-sm8550
> + - qcom,pcie-sa8775p

Sort the compatible alphabetically here and below.

- Mani

> - items:
> - const: qcom,pcie-msm8998
> - const: qcom,pcie-msm8996
> @@ -220,6 +221,7 @@ allOf:
> - qcom,pcie-sm8450-pcie0
> - qcom,pcie-sm8450-pcie1
> - qcom,pcie-sm8550
> + - qcom,pcie-sa8775p
> then:
> properties:
> reg:
> @@ -743,6 +745,30 @@ allOf:
> items:
> - const: pci # PCIe core reset
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,pcie-sa8775p
> + then:
> + properties:
> + clocks:
> + minItems: 5
> + maxItems: 5
> + clock-names:
> + items:
> + - const: aux # Auxiliary clock
> + - const: cfg # Configuration clock
> + - const: bus_master # Master AXI clock
> + - const: bus_slave # Slave AXI clock
> + - const: slave_q2a # Slave Q2A clock
> + resets:
> + maxItems: 1
> + reset-names:
> + items:
> + - const: pci # PCIe core reset
> +
> - if:
> properties:
> compatible:
> @@ -750,6 +776,7 @@ allOf:
> enum:
> - qcom,pcie-sa8540p
> - qcom,pcie-sc8280xp
> + - qcom,pcie-sa8775p
> then:
> required:
> - interconnects
> @@ -854,6 +881,7 @@ allOf:
> - qcom,pcie-ipq8074-gen3
> - qcom,pcie-qcs404
> - qcom,pcie-sa8540p
> + - qcom,pcie-sa8775p
> then:
> properties:
> interrupts:
> --
> 2.39.2
>

--
மணிவண்ணன் சதாசிவம்