2023-07-17 03:12:19

by hanyu001

Subject: [PATCH] myri10ge: Prefer unsigned int to bare use of unsigned

This patch fixes the checkpatch.pl warning:

./drivers/net/ethernet/myricom/myri10ge/myri10ge.c:629: WARNING: Prefer
'unsigned int' to bare use of 'unsigned'

Signed-off-by: maqimei <[email protected]>
---
drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index 8de2e5e..71b5f4c 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -626,7 +626,7 @@ static int myri10ge_load_hotplug_firmware(struct
myri10ge_priv *mgp, u32 * size)
vfree(fw_readback);
if (crc != reread_crc) {
dev_err(dev, "CRC failed(fw-len=%u), got 0x%x (expect 0x%x)\n",
- (unsigned)fw->size, reread_crc, crc);
+ (unsigned int)fw->size, reread_crc, crc);
status = -EIO;
goto abort_with_fw;
}

2023-07-17 06:19:01

by Leon Romanovsky

Subject: Re: [PATCH] myri10ge: Prefer unsigned int to bare use of unsigned

On Mon, Jul 17, 2023 at 10:39:41AM +0800, [email protected] wrote:
> This patch fixes the checkpatch.pl warning:
>
> ./drivers/net/ethernet/myricom/myri10ge/myri10ge.c:629: WARNING: Prefer
> 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: maqimei <[email protected]>
> ---
> drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the patch, but unfortunately netdev doesn't take pure cleanup
patches.

Thanks