2023-09-18 14:21:45

by John Watts

Subject: [RFC PATCH v2 4/9] drm/panel: nv3052c: Wait before entering sleep mode

The panel needs us to wait 120ms between exiting and entering sleep.
Guarantee that by always waiting 150ms before entering sleep mode.

Signed-off-by: John Watts <[email protected]>
---
drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
index 2526b123b1f5..307335d0f1fc 100644
--- a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
+++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
@@ -289,6 +289,9 @@ static int nv3052c_unprepare(struct drm_panel *panel)
struct mipi_dbi *dbi = &priv->dbi;
int err;

+ /* Wait 150ms in case we just exited sleep mode */
+ msleep(150);
+
err = mipi_dbi_command(dbi, MIPI_DCS_ENTER_SLEEP_MODE);
if (err)
dev_err(priv->dev, "Unable to enter sleep mode: %d\n", err);
--
2.42.0

2023-09-19 01:41:23

by Jessica Zhang

Subject: Re: [RFC PATCH v2 4/9] drm/panel: nv3052c: Wait before entering sleep mode

On 9/18/2023 5:58 AM, John Watts wrote:
> The panel needs us to wait 120ms between exiting and entering sleep.
> Guarantee that by always waiting 150ms before entering sleep mode.

Hi John,

Same question as the last patch -- is this a fix for something?

Thanks,

Jessica Zhang

>
> Signed-off-by: John Watts <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> index 2526b123b1f5..307335d0f1fc 100644
> --- a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> @@ -289,6 +289,9 @@ static int nv3052c_unprepare(struct drm_panel *panel)
> struct mipi_dbi *dbi = &priv->dbi;
> int err;
>
> + /* Wait 150ms in case we just exited sleep mode */
> + msleep(150);
> +
> err = mipi_dbi_command(dbi, MIPI_DCS_ENTER_SLEEP_MODE);
> if (err)
> dev_err(priv->dev, "Unable to enter sleep mode: %d\n", err);
> --
> 2.42.0
>