2023-09-20 07:02:17

by Raghavendra Kakarla

Subject: [PATCH] arm64: dts: qcom: Enable RPMh Sleep stats

Add device node for Sleep stats driver which provides various
low power mode stats on sa8775p SoC.

Signed-off-by: Raghavendra Kakarla <[email protected]>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 9f4f58e831a4..23ae404da02e 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -1912,6 +1912,11 @@
#clock-cells = <0>;
};

+ sram@c3f0000 {
+ compatible = "qcom,rpmh-stats";
+ reg = <0x0c3f0000 0x400>;
+ };
+
spmi_bus: spmi@c440000 {
compatible = "qcom,spmi-pmic-arb";
reg = <0x0 0x0c440000 0x0 0x1100>,
--
2.17.1

2023-09-20 12:12:29

by Konrad Dybcio

Subject: Re: [PATCH] arm64: dts: qcom: Enable RPMh Sleep stats

On 9/20/23 07:23, Raghavendra Kakarla wrote:
> Add device node for Sleep stats driver which provides various
> low power mode stats on sa8775p SoC.
>
> Signed-off-by: Raghavendra Kakarla <[email protected]>
> ---
The subject must include the platform name
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 9f4f58e831a4..23ae404da02e 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -1912,6 +1912,11 @@
> #clock-cells = <0>;
> };
>
> + sram@c3f0000 {
> + compatible = "qcom,rpmh-stats";
> + reg = <0x0c3f0000 0x400>;
Please test your patches before sending. This one has clearly
hasn't been.

Konrad

2023-09-22 09:19:21

by Raghavendra Kakarla

Subject: Re: [PATCH] arm64: dts: qcom: Enable RPMh Sleep stats

Hi Konrad,

Thank you for your review. will address your comments in next patch.


Regards,

Raghavendra K.

On 9/20/2023 3:15 PM, Konrad Dybcio wrote:
>
>
> On 9/20/23 07:23, Raghavendra Kakarla wrote:
>> Add device node for Sleep stats driver which provides various
>> low power mode stats on sa8775p SoC.
>>
>> Signed-off-by: Raghavendra Kakarla <[email protected]>
>> ---
> The subject must include the platform name
>>   arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> index 9f4f58e831a4..23ae404da02e 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> @@ -1912,6 +1912,11 @@
>>               #clock-cells = <0>;
>>           };
>>   +        sram@c3f0000 {
>> +            compatible = "qcom,rpmh-stats";
>> +            reg = <0x0c3f0000 0x400>;
> Please test your patches before sending. This one has clearly
> hasn't been.
>
> Konrad