2023-09-19 05:20:34

by Nicolin Chen

Subject: [PATCH] iommufd/selftest: Iterate idev_ids in mock_domain's alloc_hwpt test

The point in iterating variant->mock_domains is to test the idev_ids[0]
and idev_ids[1]. So use it instead of keeping testing idev_ids[0] only.

Signed-off-by: Nicolin Chen <[email protected]>
---
Jason/Kevin, I formated the patch with "-U4" so it shows the "for" line.
I didn't send it as a bug fix since it doesn't feel so critical that it
should bother stable trees -- yet if there's a need, I'd resend. Thanks!

tools/testing/selftests/iommu/iommufd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selftests/iommu/iommufd.c
index 33d08600be13..9f705c1ea30f 100644
--- a/tools/testing/selftests/iommu/iommufd.c
+++ b/tools/testing/selftests/iommu/iommufd.c
@@ -1406,9 +1406,9 @@ TEST_F(iommufd_mock_domain, alloc_hwpt)
for (i = 0; i != variant->mock_domains; i++) {
uint32_t stddev_id;
uint32_t hwpt_id;

- test_cmd_hwpt_alloc(self->idev_ids[0], self->ioas_id, &hwpt_id);
+ test_cmd_hwpt_alloc(self->idev_ids[i], self->ioas_id, &hwpt_id);
test_cmd_mock_domain(hwpt_id, &stddev_id, NULL, NULL);
test_ioctl_destroy(stddev_id);
test_ioctl_destroy(hwpt_id);
}
--
2.42.0

2023-09-26 15:36:50

by Tian, Kevin

Subject: RE: [PATCH] iommufd/selftest: Iterate idev_ids in mock_domain's alloc_hwpt test

> From: Nicolin Chen <[email protected]>
> Sent: Tuesday, September 19, 2023 9:17 AM
>
> The point in iterating variant->mock_domains is to test the idev_ids[0]
> and idev_ids[1]. So use it instead of keeping testing idev_ids[0] only.
>
> Signed-off-by: Nicolin Chen <[email protected]>

Reviewed-by: Kevin Tian <[email protected]>

2023-09-26 17:37:49

by Jason Gunthorpe

Subject: Re: [PATCH] iommufd/selftest: Iterate idev_ids in mock_domain's alloc_hwpt test

On Mon, Sep 18, 2023 at 06:16:37PM -0700, Nicolin Chen wrote:
> The point in iterating variant->mock_domains is to test the idev_ids[0]
> and idev_ids[1]. So use it instead of keeping testing idev_ids[0] only.
>
> Signed-off-by: Nicolin Chen <[email protected]>
> ---
> Jason/Kevin, I formated the patch with "-U4" so it shows the "for" line.
> I didn't send it as a bug fix since it doesn't feel so critical that it
> should bother stable trees -- yet if there's a need, I'd resend. Thanks!
>
> tools/testing/selftests/iommu/iommufd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to iommufd for-next

Thanks,
Jason