2023-09-28 15:16:38

by Adrian Hunter

Subject: [PATCH] perf dlfilter: Add a test for object_code()

Extend the "dlfilter C API" test to test
perf_dlfilter_fns.object_code().

Signed-off-by: Adrian Hunter <[email protected]>
---
tools/perf/dlfilters/dlfilter-test-api-v0.c | 12 +++++++++++-
tools/perf/dlfilters/dlfilter-test-api-v2.c | 12 +++++++++++-
2 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/tools/perf/dlfilters/dlfilter-test-api-v0.c b/tools/perf/dlfilters/dlfilter-test-api-v0.c
index 72f263d49121..4083b1abeaab 100644
--- a/tools/perf/dlfilters/dlfilter-test-api-v0.c
+++ b/tools/perf/dlfilters/dlfilter-test-api-v0.c
@@ -289,6 +289,15 @@ static int check_attr(void *ctx)
return 0;
}

+static int check_object_code(void *ctx, const struct perf_dlfilter_sample *sample)
+{
+ __u8 buf[15];
+
+ CHECK(perf_dlfilter_fns.object_code(ctx, sample->ip, buf, sizeof(buf)) > 0);
+
+ return 0;
+}
+
static int do_checks(void *data, const struct perf_dlfilter_sample *sample, void *ctx, bool early)
{
struct filter_data *d = data;
@@ -314,7 +323,8 @@ static int do_checks(void *data, const struct perf_dlfilter_sample *sample, void
if (early && !d->do_early)
return 0;

- if (check_al(ctx) || check_addr_al(ctx) || check_address_al(ctx, sample))
+ if (check_al(ctx) || check_addr_al(ctx) || check_address_al(ctx, sample) ||
+ check_object_code(ctx, sample))
return -1;

if (early)
diff --git a/tools/perf/dlfilters/dlfilter-test-api-v2.c b/tools/perf/dlfilters/dlfilter-test-api-v2.c
index 38e593d92920..32ff619e881c 100644
--- a/tools/perf/dlfilters/dlfilter-test-api-v2.c
+++ b/tools/perf/dlfilters/dlfilter-test-api-v2.c
@@ -308,6 +308,15 @@ static int check_attr(void *ctx)
return 0;
}

+static int check_object_code(void *ctx, const struct perf_dlfilter_sample *sample)
+{
+ __u8 buf[15];
+
+ CHECK(perf_dlfilter_fns.object_code(ctx, sample->ip, buf, sizeof(buf)) > 0);
+
+ return 0;
+}
+
static int do_checks(void *data, const struct perf_dlfilter_sample *sample, void *ctx, bool early)
{
struct filter_data *d = data;
@@ -333,7 +342,8 @@ static int do_checks(void *data, const struct perf_dlfilter_sample *sample, void
if (early && !d->do_early)
return 0;

- if (check_al(ctx) || check_addr_al(ctx) || check_address_al(ctx, sample))
+ if (check_al(ctx) || check_addr_al(ctx) || check_address_al(ctx, sample) ||
+ check_object_code(ctx, sample))
return -1;

if (early)
--
2.34.1

2023-10-12 21:43:41

by Ian Rogers

Subject: Re: [PATCH] perf dlfilter: Add a test for object_code()

On Thu, Sep 28, 2023 at 2:10 AM Adrian Hunter <[email protected]> wrote:
>
> Extend the "dlfilter C API" test to test
> perf_dlfilter_fns.object_code().
>
> Signed-off-by: Adrian Hunter <[email protected]>

Tested-by: Ian Rogers <[email protected]>

Thanks,
Ian

> ---
> tools/perf/dlfilters/dlfilter-test-api-v0.c | 12 +++++++++++-
> tools/perf/dlfilters/dlfilter-test-api-v2.c | 12 +++++++++++-
> 2 files changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/dlfilters/dlfilter-test-api-v0.c b/tools/perf/dlfilters/dlfilter-test-api-v0.c
> index 72f263d49121..4083b1abeaab 100644
> --- a/tools/perf/dlfilters/dlfilter-test-api-v0.c
> +++ b/tools/perf/dlfilters/dlfilter-test-api-v0.c
> @@ -289,6 +289,15 @@ static int check_attr(void *ctx)
> return 0;
> }
>
> +static int check_object_code(void *ctx, const struct perf_dlfilter_sample *sample)
> +{
> + __u8 buf[15];
> +
> + CHECK(perf_dlfilter_fns.object_code(ctx, sample->ip, buf, sizeof(buf)) > 0);
> +
> + return 0;
> +}
> +
> static int do_checks(void *data, const struct perf_dlfilter_sample *sample, void *ctx, bool early)
> {
> struct filter_data *d = data;
> @@ -314,7 +323,8 @@ static int do_checks(void *data, const struct perf_dlfilter_sample *sample, void
> if (early && !d->do_early)
> return 0;
>
> - if (check_al(ctx) || check_addr_al(ctx) || check_address_al(ctx, sample))
> + if (check_al(ctx) || check_addr_al(ctx) || check_address_al(ctx, sample) ||
> + check_object_code(ctx, sample))
> return -1;
>
> if (early)
> diff --git a/tools/perf/dlfilters/dlfilter-test-api-v2.c b/tools/perf/dlfilters/dlfilter-test-api-v2.c
> index 38e593d92920..32ff619e881c 100644
> --- a/tools/perf/dlfilters/dlfilter-test-api-v2.c
> +++ b/tools/perf/dlfilters/dlfilter-test-api-v2.c
> @@ -308,6 +308,15 @@ static int check_attr(void *ctx)
> return 0;
> }
>
> +static int check_object_code(void *ctx, const struct perf_dlfilter_sample *sample)
> +{
> + __u8 buf[15];
> +
> + CHECK(perf_dlfilter_fns.object_code(ctx, sample->ip, buf, sizeof(buf)) > 0);
> +
> + return 0;
> +}
> +
> static int do_checks(void *data, const struct perf_dlfilter_sample *sample, void *ctx, bool early)
> {
> struct filter_data *d = data;
> @@ -333,7 +342,8 @@ static int do_checks(void *data, const struct perf_dlfilter_sample *sample, void
> if (early && !d->do_early)
> return 0;
>
> - if (check_al(ctx) || check_addr_al(ctx) || check_address_al(ctx, sample))
> + if (check_al(ctx) || check_addr_al(ctx) || check_address_al(ctx, sample) ||
> + check_object_code(ctx, sample))
> return -1;
>
> if (early)
> --
> 2.34.1
>