2023-10-03 16:48:47

by Johannes Weiner

[permalink] [raw]
Subject: Re: [PATCH v1 1/5] mm: kmem: optimize get_obj_cgroup_from_current()

On Fri, Sep 29, 2023 at 11:00:51AM -0700, Roman Gushchin wrote:
> Manually inline memcg_kmem_bypass() and active_memcg() to speed up
> get_obj_cgroup_from_current() by avoiding duplicate in_task() checks
> and active_memcg() readings.
>
> Also add a likely() macro to __get_obj_cgroup_from_memcg():
> obj_cgroup_tryget() should succeed at almost all times except a very
> unlikely race with the memcg deletion path.
>
> Signed-off-by: Roman Gushchin (Cruise) <[email protected]>
> Acked-by: Shakeel Butt <[email protected]>

Acked-by: Johannes Weiner <[email protected]>