2023-10-10 17:27:50

by Duje Mihanović

Subject: [PATCH v6 2/9] dt-bindings: pinctrl: pinctrl-single: add marvell,pxa1908-padconf compatible

Add the "marvell,pxa1908-padconf" compatible to allow migrating to a
separate pinctrl driver later.

Signed-off-by: Duje Mihanović <[email protected]>
---
Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
index 45a307d3ce16..0f7e16a28990 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
@@ -32,6 +32,10 @@ properties:
- ti,omap4-padconf
- ti,omap5-padconf
- const: pinctrl-single
+ - items:
+ - enum:
+ - marvell,pxa1908-padconf
+ - const: pinconf-single

reg:
maxItems: 1

--
2.42.0

2023-10-12 19:53:10

by Krzysztof Kozlowski

Subject: Re: [PATCH v6 2/9] dt-bindings: pinctrl: pinctrl-single: add marvell,pxa1908-padconf compatible

On 10/10/2023 19:27, Duje Mihanović wrote:
> Add the "marvell,pxa1908-padconf" compatible to allow migrating to a
> separate pinctrl driver later.
>
> Signed-off-by: Duje Mihanović <[email protected]>
> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> index 45a307d3ce16..0f7e16a28990 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> @@ -32,6 +32,10 @@ properties:
> - ti,omap4-padconf
> - ti,omap5-padconf
> - const: pinctrl-single
> + - items:
> + - enum:
> + - marvell,pxa1908-padconf

There is enum above, so use it. Put your entry there, in alphabetical order.

Best regards,
Krzysztof

2023-10-12 19:54:16

by Rob Herring (Arm)

Subject: Re: [PATCH v6 2/9] dt-bindings: pinctrl: pinctrl-single: add marvell,pxa1908-padconf compatible

On Tue, Oct 10, 2023 at 07:27:19PM +0200, Duje Mihanović wrote:
> Add the "marvell,pxa1908-padconf" compatible to allow migrating to a
> separate pinctrl driver later.
>
> Signed-off-by: Duje Mihanović <[email protected]>
> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> index 45a307d3ce16..0f7e16a28990 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> @@ -32,6 +32,10 @@ properties:
> - ti,omap4-padconf
> - ti,omap5-padconf
> - const: pinctrl-single
> + - items:
> + - enum:
> + - marvell,pxa1908-padconf

Just add this to the existing enum above.

Rob

2023-10-12 19:59:54

by Rob Herring (Arm)

Subject: Re: [PATCH v6 2/9] dt-bindings: pinctrl: pinctrl-single: add marvell,pxa1908-padconf compatible

On Thu, Oct 12, 2023 at 2:53 PM Rob Herring <[email protected]> wrote:
>
> On Tue, Oct 10, 2023 at 07:27:19PM +0200, Duje Mihanović wrote:
> > Add the "marvell,pxa1908-padconf" compatible to allow migrating to a
> > separate pinctrl driver later.
> >
> > Signed-off-by: Duje Mihanović <[email protected]>
> > ---
> > Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> > index 45a307d3ce16..0f7e16a28990 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
> > @@ -32,6 +32,10 @@ properties:
> > - ti,omap4-padconf
> > - ti,omap5-padconf
> > - const: pinctrl-single
> > + - items:
> > + - enum:
> > + - marvell,pxa1908-padconf
>
> Just add this to the existing enum above.

NM, I see it's pinconf-single, not pinctrl-single.

Reviewed-by: Rob Herring <[email protected]>