2023-10-13 05:16:20

by Soumya Negi

Subject: [PATCH] tty: gdm724x: Fix coding style checkpatch warnings

Add blank line after declaration & match alignment with open parenthesis.
Issue found by checkpatch.pl

Signed-off-by: Soumya Negi <[email protected]>
---
drivers/staging/gdm724x/gdm_tty.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index 32b2e817ff04..0c61eaff6122 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -160,6 +160,7 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len)

while (remain) {
size_t sending_len = min_t(size_t, MUX_TX_MAX_SIZE, remain);
+
gdm->tty_dev->send_func(gdm->tty_dev->priv_dev,
(void *)(buf + sent_len),
sending_len,
@@ -271,8 +272,8 @@ int register_lte_tty_driver(void)
int ret;

for (i = 0; i < TTY_MAX_COUNT; i++) {
- tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
- TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
+ tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
+ TTY_DRIVER_DYNAMIC_DEV);
if (IS_ERR(tty_driver))
return PTR_ERR(tty_driver);

--
2.42.0

2023-10-13 05:21:34

by Julia Lawall

Subject: Re: [PATCH] tty: gdm724x: Fix coding style checkpatch warnings

On Thu, 12 Oct 2023, Soumya Negi wrote:

> Add blank line after declaration & match alignment with open parenthesis.
> Issue found by checkpatch.pl

This seems like two completely unrelated issues.

julia

>
> Signed-off-by: Soumya Negi <[email protected]>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 32b2e817ff04..0c61eaff6122 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -160,6 +160,7 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len)
>
> while (remain) {
> size_t sending_len = min_t(size_t, MUX_TX_MAX_SIZE, remain);
> +
> gdm->tty_dev->send_func(gdm->tty_dev->priv_dev,
> (void *)(buf + sent_len),
> sending_len,
> @@ -271,8 +272,8 @@ int register_lte_tty_driver(void)
> int ret;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> - tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> + TTY_DRIVER_DYNAMIC_DEV);
> if (IS_ERR(tty_driver))
> return PTR_ERR(tty_driver);
>
> --
> 2.42.0
>
>
>

2023-10-13 05:35:20

by Soumya Negi

Subject: Re: [PATCH] tty: gdm724x: Fix coding style checkpatch warnings

On Fri, Oct 13, 2023 at 07:20:08AM +0200, Julia Lawall wrote:
>
>
> On Thu, 12 Oct 2023, Soumya Negi wrote:
>
> > Add blank line after declaration & match alignment with open parenthesis.
> > Issue found by checkpatch.pl
>
> This seems like two completely unrelated issues.
>
> julia

Hi Julia,

I got it. Will send two separate patches for each type of code cleanup.

- Soumya

> >
> > Signed-off-by: Soumya Negi <[email protected]>
> > ---
> > drivers/staging/gdm724x/gdm_tty.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> > index 32b2e817ff04..0c61eaff6122 100644
> > --- a/drivers/staging/gdm724x/gdm_tty.c
> > +++ b/drivers/staging/gdm724x/gdm_tty.c
> > @@ -160,6 +160,7 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len)
> >
> > while (remain) {
> > size_t sending_len = min_t(size_t, MUX_TX_MAX_SIZE, remain);
> > +
> > gdm->tty_dev->send_func(gdm->tty_dev->priv_dev,
> > (void *)(buf + sent_len),
> > sending_len,
> > @@ -271,8 +272,8 @@ int register_lte_tty_driver(void)
> > int ret;
> >
> > for (i = 0; i < TTY_MAX_COUNT; i++) {
> > - tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> > - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> > + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> > + TTY_DRIVER_DYNAMIC_DEV);
> > if (IS_ERR(tty_driver))
> > return PTR_ERR(tty_driver);
> >
> > --
> > 2.42.0
> >
> >
> >

2023-10-13 08:53:48

by Dan Carpenter

Subject: Re: [PATCH] tty: gdm724x: Fix coding style checkpatch warnings

On Thu, Oct 12, 2023 at 10:14:58PM -0700, Soumya Negi wrote:
> @@ -271,8 +272,8 @@ int register_lte_tty_driver(void)
> int ret;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> - tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> + TTY_DRIVER_DYNAMIC_DEV);

Don't do this. The code was better before. The parameter
"TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV" is one thing and
splitting it up like that makes the code less readable. And I bet they
had to indent it like that to get under the 80 character limit.

This is an example of checkpatch giving bad advice.

regards,
dan carpenter

2023-10-13 21:19:33

by Soumya Negi

Subject: Re: [PATCH] tty: gdm724x: Fix coding style checkpatch warnings

On Fri, Oct 13, 2023 at 11:53:36AM +0300, Dan Carpenter wrote:
> On Thu, Oct 12, 2023 at 10:14:58PM -0700, Soumya Negi wrote:
> > @@ -271,8 +272,8 @@ int register_lte_tty_driver(void)
> > int ret;
> >
> > for (i = 0; i < TTY_MAX_COUNT; i++) {
> > - tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> > - TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV);
> > + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, TTY_DRIVER_REAL_RAW |
> > + TTY_DRIVER_DYNAMIC_DEV);
>
> Don't do this. The code was better before. The parameter
> "TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV" is one thing and
> splitting it up like that makes the code less readable. And I bet they
> had to indent it like that to get under the 80 character limit.
>
> This is an example of checkpatch giving bad advice.

Hi Dan,

Will keep this in mind for other similar checkpatch warnings.

Thanks,
Soumya

> regards,
> dan carpenter
>