2023-12-01 13:51:12

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH 0/2] arm64: dts: qcom: enable IPA on sm8650

Add the basic DTS information for supporting IPA on the Qualcomm
SM8650 SoC. Enable IPA on the SM8650 QRD platform; GSI firmware is
loaded by the AP in this case.

Tested on SM8650 QRD:
[ 5.764240] ipa 3f40000.ipa: IPA driver initialized
[ 5.787438] ipa 3f40000.ipa: IPA driver setup completed successfully
[ 7.446693] ipa 3f40000.ipa: received modem starting event
[ 8.413152] ipa 3f40000.ipa: received modem running event

Depends on SM8650 Initial DT at [0], bindings at [1]

[0] https://lore.kernel.org/all/[email protected]/
[1] https://lore.kernel.org/all/20231129-topic-sm8650-upstream-bindings-ipa-v1-1-ca21eb2dfb14@linaro.org/

Signed-off-by: Neil Armstrong <[email protected]>
---
Neil Armstrong (2):
arm64: dts: qcom: sm8650: add IPA information
arm64: dts: qcom: sm8650-qrd: enable IPA

arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 7 ++++++
arch/arm64/boot/dts/qcom/sm8650.dtsi | 39 +++++++++++++++++++++++++++++++++
2 files changed, 46 insertions(+)
---
base-commit: 25cb94419a71435991cc8844251ffc0194f4dc8e
change-id: 20231129-topic-sm8650-upstream-ipa-084b42c5f943

Best regards,
--
Neil Armstrong <[email protected]>


2023-12-01 13:51:46

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH 1/2] arm64: dts: qcom: sm8650: add IPA information

Add IPA-related nodes and definitions to SM8650 dtsi,
which uses IPA v5.5.1 a minor revision of v5.5 found
in the SM8550 SoC.

Signed-off-by: Neil Armstrong <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8650.dtsi | 39 ++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
index 41dfa5e19a15..13dc1305109b 100644
--- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
@@ -2558,6 +2558,45 @@ gpucc: clock-controller@3d90000 {
#power-domain-cells = <1>;
};

+ ipa: ipa@3f40000 {
+ compatible = "qcom,sm8650-ipa", "qcom,sm8550-ipa";
+
+ iommus = <&apps_smmu 0x4a0 0x0>,
+ <&apps_smmu 0x4a2 0x0>;
+ reg = <0 0x3f40000 0 0x10000>,
+ <0 0x3f50000 0 0x5000>,
+ <0 0x3e04000 0 0xfc000>;
+ reg-names = "ipa-reg",
+ "ipa-shared",
+ "gsi";
+
+ interrupts-extended = <&intc GIC_SPI 654 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>,
+ <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
+ <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "ipa",
+ "gsi",
+ "ipa-clock-query",
+ "ipa-setup-ready";
+
+ clocks = <&rpmhcc RPMH_IPA_CLK>;
+ clock-names = "core";
+
+ interconnects = <&aggre2_noc MASTER_IPA 0 &mc_virt SLAVE_EBI1 0>,
+ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_IPA_CFG 0>;
+ interconnect-names = "memory",
+ "config";
+
+ qcom,qmp = <&aoss_qmp>;
+
+ qcom,smem-states = <&ipa_smp2p_out 0>,
+ <&ipa_smp2p_out 1>;
+ qcom,smem-state-names = "ipa-clock-enabled-valid",
+ "ipa-clock-enabled";
+
+ status = "disabled";
+ };
+
remoteproc_mpss: remoteproc@4080000 {
compatible = "qcom,sm8650-mpss-pas";
reg = <0 0x04080000 0 0x4040>;

--
2.34.1

2023-12-01 13:51:48

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: qcom: sm8650-qrd: enable IPA

Enable IPA on the SM8650 QRD. The GSI firmware on this platform is
loaded by the AP.

Signed-off-by: Neil Armstrong <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
index e69ae61b6111..592a67a47c78 100644
--- a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
@@ -446,6 +446,13 @@ &gpi_dma1 {
status = "okay";
};

+&ipa {
+ qcom,gsi-loader = "self";
+ memory-region = <&ipa_fw_mem>;
+ firmware-name = "qcom/sm8650/ipa_fws.mbn";
+ status = "okay";
+};
+
&mdss {
status = "okay";
};

--
2.34.1

2023-12-08 14:51:48

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH 0/2] arm64: dts: qcom: enable IPA on sm8650


On Fri, 01 Dec 2023 14:50:40 +0100, Neil Armstrong wrote:
> Add the basic DTS information for supporting IPA on the Qualcomm
> SM8650 SoC. Enable IPA on the SM8650 QRD platform; GSI firmware is
> loaded by the AP in this case.
>
> Tested on SM8650 QRD:
> [ 5.764240] ipa 3f40000.ipa: IPA driver initialized
> [ 5.787438] ipa 3f40000.ipa: IPA driver setup completed successfully
> [ 7.446693] ipa 3f40000.ipa: received modem starting event
> [ 8.413152] ipa 3f40000.ipa: received modem running event
>
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: sm8650: add IPA information
commit: 9fdddbd134a68843364c3e8c57fbdc5da2a7083d
[2/2] arm64: dts: qcom: sm8650-qrd: enable IPA
commit: 83c054b913cf6accd4cb31cee51729b322bde7fb

Best regards,
--
Bjorn Andersson <[email protected]>