2024-02-05 13:57:11

by Markus Elfring

Subject: [PATCH] net: emaclite: Use devm_platform_get_and_ioremap_resource() in xemaclite_of_probe()

From: Markus Elfring <[email protected]>
Date: Mon, 5 Feb 2024 14:44:20 +0100

A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/net/ethernet/xilinx/xilinx_emaclite.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
index 765aa516aada..940452d0a4d2 100644
--- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
+++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
@@ -1114,8 +1114,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev)

ndev->irq = rc;

- res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
- lp->base_addr = devm_ioremap_resource(&ofdev->dev, res);
+ lp->base_addr = devm_platform_get_and_ioremap_resource(ofdev, 0, &res);
if (IS_ERR(lp->base_addr)) {
rc = PTR_ERR(lp->base_addr);
goto error;
--
2.43.0

2024-02-09 21:42:54

by Jakub Kicinski

Subject: Re: [PATCH] net: emaclite: Use devm_platform_get_and_ioremap_resource() in xemaclite_of_probe()

Applied, thanks, but in the future please make sure that:

On Mon, 5 Feb 2024 14:55:23 +0100 Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Mon, 5 Feb 2024 14:44:20 +0100

You use git-send-email or otherwise get rid of these extra lines.
They appear to confuse the kernel.org patchwork reply bot.

> A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6

trim hashes to 12 characters.

> ("drivers: provide devm_platform_get_and_ioremap_resource()").
> Thus reuse existing functionality instead of keeping duplicate source code.
>
> This issue was detected by using the Coccinelle software.