2024-04-05 14:20:31

by I Hsin Cheng

Subject: [PATCH] netlink: Remove the include of files doesn't exist

The file for /security/selinux/security.h and the file for
/include/linux/selinux_netlink.h are no long exist. However the
preprocessor still performs the inclusion of those files, these
behaviors should be removed to ensure it's bug-free.

Signed-off-by: I Hsin Cheng <[email protected]>
---
security/selinux/netlink.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/security/selinux/netlink.c b/security/selinux/netlink.c
index 1760aee71..8ce36abaa 100644
--- a/security/selinux/netlink.c
+++ b/security/selinux/netlink.c
@@ -13,11 +13,9 @@
#include <linux/kernel.h>
#include <linux/export.h>
#include <linux/skbuff.h>
-#include <linux/selinux_netlink.h>
#include <net/net_namespace.h>
#include <net/netlink.h>

-#include "security.h"

static struct sock *selnl __ro_after_init;

--
2.34.1

2024-04-05 16:04:10

by Stephen Smalley

Subject: Re: [PATCH] netlink: Remove the include of files doesn't exist

On Fri, Apr 5, 2024 at 10:19 AM I Hsin Cheng <[email protected]> wrote:
>
> The file for /security/selinux/security.h and the file for
> /include/linux/selinux_netlink.h are no long exist. However the
> preprocessor still performs the inclusion of those files, these
> behaviors should be removed to ensure it's bug-free.
>
> Signed-off-by: I Hsin Cheng <[email protected]>

NAK. You are incorrect on both counts and evidently didn't try compiling.
At a purely source level, I agree it might look confusing, but the
Makefile adds the security/selinux/include directory (where security.h
lives) to the include path and selinux_netlink.h lives under
include/uapi/linux which is auto-magically included.

> ---
> security/selinux/netlink.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/security/selinux/netlink.c b/security/selinux/netlink.c
> index 1760aee71..8ce36abaa 100644
> --- a/security/selinux/netlink.c
> +++ b/security/selinux/netlink.c
> @@ -13,11 +13,9 @@
> #include <linux/kernel.h>
> #include <linux/export.h>
> #include <linux/skbuff.h>
> -#include <linux/selinux_netlink.h>
> #include <net/net_namespace.h>
> #include <net/netlink.h>
>
> -#include "security.h"
>
> static struct sock *selnl __ro_after_init;
>
> --
> 2.34.1
>