2024-05-06 12:47:14

by Heiko Stuebner

[permalink] [raw]
Subject: [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon

From: Heiko Stuebner <[email protected]>

RK3588 CSI and DSI support requires the GRF for DC-PHY.

Signed-off-by: Heiko Stuebner <[email protected]>
---
Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
index 0b87c266760c6..0131c62893450 100644
--- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
+++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
@@ -22,6 +22,7 @@ properties:
- rockchip,rk3568-usb2phy-grf
- rockchip,rk3588-bigcore0-grf
- rockchip,rk3588-bigcore1-grf
+ - rockchip,rk3588-dcphy-grf
- rockchip,rk3588-hdptxphy-grf
- rockchip,rk3588-ioc
- rockchip,rk3588-php-grf
--
2.39.2



2024-05-07 15:09:32

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon

On Mon, May 06, 2024 at 02:46:32PM +0200, Heiko Stuebner wrote:
> From: Heiko Stuebner <[email protected]>
>
> RK3588 CSI and DSI support requires the GRF for DC-PHY.
>
> Signed-off-by: Heiko Stuebner <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Cheers,
Conor.

Attachments:
(No filename) (317.00 B)
 signature.asc (235.00 B)
 Download all attachments

2024-05-07 16:50:58

by Quentin Schulz

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon

Hi Heiko,

On 5/6/24 2:46 PM, Heiko Stuebner wrote:
> From: Heiko Stuebner <[email protected]>
>
> RK3588 CSI and DSI support requires the GRF for DC-PHY.
>
> Signed-off-by: Heiko Stuebner <[email protected]>
> ---
> Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> index 0b87c266760c6..0131c62893450 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> @@ -22,6 +22,7 @@ properties:
> - rockchip,rk3568-usb2phy-grf
> - rockchip,rk3588-bigcore0-grf
> - rockchip,rk3588-bigcore1-grf
> + - rockchip,rk3588-dcphy-grf

There are two. While the TRM states:

"""
There are two MIPICDPHY_GRF modules in RK3588.They have different base
address.
"""

(ignore the typo :) )

it states the same for the bigcore grf but we have two bindings for them
in there... So not sure what to go for here? Similarly, pipe-grf has
three instances but we define only one binding...

So who knows :)

That being said,
Reviewed-by: Quentin Schulz <[email protected]>

Thanks!
Quentin