2024-05-09 10:53:09

by Krzysztof Kozlowski

Subject: [PATCH] ARM: dts: ti: align panel timings node name with dtschema

DT schema expects panel timings node to follow certain pattern,
dtbs_check warnings:

am335x-pdu001.dtb: display-timings: '240x320p16' does not match any of the regexes: '^timing', 'pinctrl-[0-9]+'

Linux drivers do not care about node name, so this should not have
effect on Linux.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/ti/davinci/da850-evm.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-guardian.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-pdu001.dts | 2 +-
arch/arm/boot/dts/ti/omap/am335x-pepper.dts | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/ti/davinci/da850-evm.dts b/arch/arm/boot/dts/ti/davinci/da850-evm.dts
index 6c5936278e75..1f5cd35f8b74 100644
--- a/arch/arm/boot/dts/ti/davinci/da850-evm.dts
+++ b/arch/arm/boot/dts/ti/davinci/da850-evm.dts
@@ -65,7 +65,7 @@ panel-info {

display-timings {
native-mode = <&timing0>;
- timing0: 480x272 {
+ timing0: timing-480x272 {
clock-frequency = <9000000>;
hactive = <480>;
vactive = <272>;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-guardian.dts b/arch/arm/boot/dts/ti/omap/am335x-guardian.dts
index 56e5d954a490..4b070e634b28 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-guardian.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-guardian.dts
@@ -74,7 +74,7 @@ panel {
pinctrl-1 = <&lcd_pins_sleep>;

display-timings {
- 320x240 {
+ timing-320x240 {
hactive = <320>;
vactive = <240>;
hback-porch = <68>;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-pdu001.dts b/arch/arm/boot/dts/ti/omap/am335x-pdu001.dts
index f38f5bff2b96..17574d0d0525 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-pdu001.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-pdu001.dts
@@ -67,7 +67,7 @@ panel-info {
};

display-timings {
- 240x320p16 {
+ timing-240x320p16 {
clock-frequency = <6500000>;
hactive = <240>;
vactive = <320>;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-pepper.dts b/arch/arm/boot/dts/ti/omap/am335x-pepper.dts
index d5a4a21889d1..e7d561a527fd 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-pepper.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-pepper.dts
@@ -202,7 +202,7 @@ panel-info {
};
display-timings {
native-mode = <&timing0>;
- timing0: 480x272 {
+ timing0: timing-480x272 {
clock-frequency = <18400000>;
hactive = <480>;
vactive = <272>;
--
2.43.0

2024-05-09 13:10:03

by Bartosz Golaszewski

Subject: Re: [PATCH] ARM: dts: ti: align panel timings node name with dtschema

On Thu, May 9, 2024 at 12:48 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> DT schema expects panel timings node to follow certain pattern,
> dtbs_check warnings:
>
> am335x-pdu001.dtb: display-timings: '240x320p16' does not match any of the regexes: '^timing', 'pinctrl-[0-9]+'
>
> Linux drivers do not care about node name, so this should not have
> effect on Linux.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm/boot/dts/ti/davinci/da850-evm.dts | 2 +-
> arch/arm/boot/dts/ti/omap/am335x-guardian.dts | 2 +-
> arch/arm/boot/dts/ti/omap/am335x-pdu001.dts | 2 +-
> arch/arm/boot/dts/ti/omap/am335x-pepper.dts | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ti/davinci/da850-evm.dts b/arch/arm/boot/dts/ti/davinci/da850-evm.dts
> index 6c5936278e75..1f5cd35f8b74 100644
> --- a/arch/arm/boot/dts/ti/davinci/da850-evm.dts
> +++ b/arch/arm/boot/dts/ti/davinci/da850-evm.dts
> @@ -65,7 +65,7 @@ panel-info {
>
> display-timings {
> native-mode = <&timing0>;
> - timing0: 480x272 {
> + timing0: timing-480x272 {
> clock-frequency = <9000000>;
> hactive = <480>;
> vactive = <272>;

Acked-by: Bartosz Golaszewski <[email protected]> # For DaVinci