2020-01-21 22:30:31

by Heiko Stuebner

Subject: [PATCH] PM / AVS: rockchip-io: fix the supply naming for the emmc supply on px30

From: Heiko Stuebner <[email protected]>

The supply going to the emmc/flash is named vccio6, not vccio0 and while
the code does this correctly already, the comments and error output do not.

So just change these values to the correct ones.

Signed-off-by: Heiko Stuebner <[email protected]>
---
drivers/power/avs/rockchip-io-domain.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/power/avs/rockchip-io-domain.c b/drivers/power/avs/rockchip-io-domain.c
index 398fc954419e..eece97f97ef8 100644
--- a/drivers/power/avs/rockchip-io-domain.c
+++ b/drivers/power/avs/rockchip-io-domain.c
@@ -152,18 +152,18 @@ static void px30_iodomain_init(struct rockchip_iodomain *iod)
int ret;
u32 val;

- /* if no VCCIO0 supply we should leave things alone */
+ /* if no VCCIO6 supply we should leave things alone */
if (!iod->supplies[PX30_IO_VSEL_VCCIO6_SUPPLY_NUM].reg)
return;

/*
- * set vccio0 iodomain to also use this framework
+ * set vccio6 iodomain to also use this framework
* instead of a special gpio.
*/
val = PX30_IO_VSEL_VCCIO6_SRC | (PX30_IO_VSEL_VCCIO6_SRC << 16);
ret = regmap_write(iod->grf, PX30_IO_VSEL, val);
if (ret < 0)
- dev_warn(iod->dev, "couldn't update vccio0 ctrl\n");
+ dev_warn(iod->dev, "couldn't update vccio6 ctrl\n");
}

static void rk3288_iodomain_init(struct rockchip_iodomain *iod)
--
2.24.1

2020-02-23 15:10:03

by Heiko Stuebner

Subject: Re: [PATCH] PM / AVS: rockchip-io: fix the supply naming for the emmc supply on px30

Hi,

Am Dienstag, 21. Januar 2020, 23:28:59 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner <[email protected]>
>
> The supply going to the emmc/flash is named vccio6, not vccio0 and while
> the code does this correctly already, the comments and error output do not.
>
> So just change these values to the correct ones.
>
> Signed-off-by: Heiko Stuebner <[email protected]>

oh so gently ping on this tiny patch ;-)

Thanks for considering
Heiko

> ---
> drivers/power/avs/rockchip-io-domain.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/avs/rockchip-io-domain.c b/drivers/power/avs/rockchip-io-domain.c
> index 398fc954419e..eece97f97ef8 100644
> --- a/drivers/power/avs/rockchip-io-domain.c
> +++ b/drivers/power/avs/rockchip-io-domain.c
> @@ -152,18 +152,18 @@ static void px30_iodomain_init(struct rockchip_iodomain *iod)
> int ret;
> u32 val;
>
> - /* if no VCCIO0 supply we should leave things alone */
> + /* if no VCCIO6 supply we should leave things alone */
> if (!iod->supplies[PX30_IO_VSEL_VCCIO6_SUPPLY_NUM].reg)
> return;
>
> /*
> - * set vccio0 iodomain to also use this framework
> + * set vccio6 iodomain to also use this framework
> * instead of a special gpio.
> */
> val = PX30_IO_VSEL_VCCIO6_SRC | (PX30_IO_VSEL_VCCIO6_SRC << 16);
> ret = regmap_write(iod->grf, PX30_IO_VSEL, val);
> if (ret < 0)
> - dev_warn(iod->dev, "couldn't update vccio0 ctrl\n");
> + dev_warn(iod->dev, "couldn't update vccio6 ctrl\n");
> }
>
> static void rk3288_iodomain_init(struct rockchip_iodomain *iod)
>

2020-03-11 21:47:28

by Kevin Hilman

Subject: Re: [PATCH] PM / AVS: rockchip-io: fix the supply naming for the emmc supply on px30

Heiko Stuebner <[email protected]> writes:

> From: Heiko Stuebner <[email protected]>
>
> The supply going to the emmc/flash is named vccio6, not vccio0 and while
> the code does this correctly already, the comments and error output do not.
>
> So just change these values to the correct ones.
>
> Signed-off-by: Heiko Stuebner <[email protected]>

Reviewed-by: Kevin Hilman <[email protected]>

Raafael, feel free to apply directly.

Thanks,

Kevin