2024-06-05 09:13:57

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH v8 01/17] regulator: dt-bindings: describe the PMU module of the QCA6390 package

On Tue, Jun 4, 2024 at 7:30 PM Bjorn Helgaas <[email protected]> wrote:
>
> On Tue, May 28, 2024 at 09:03:09PM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <[email protected]>
> >
> > The QCA6390 package contains discreet modules for WLAN and Bluetooth. They
>
> s/discreet/discrete/
>
> > are powered by the Power Management Unit (PMU) that takes inputs from the
> > host and provides LDO outputs. This document describes this module.
>
> LDO? Again below, but maybe this is obvious to everybody.
>

Yes, this is an acceptable abbreviation to use, it's all over the
bindings and regulator drivers.

> "This document describes this module" seems possibly unnecessary.
>
> > +description:
> > + The QCA6390 package contains discreet modules for WLAN and Bluetooth. They
>
> s/discreet/discrete/
>
> > + are powered by the Power Management Unit (PMU) that takes inputs from the
> > + host and provides LDO outputs. This document describes this module.
>
> > + vddpcie1p3-supply:
> > + description: VDD_PCIE_1P3 supply regulator handle<S-Del>
>
> s/<S-Del>// ?

Eek, bad copy-paste.

Bart


2024-06-05 11:13:15

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v8 01/17] regulator: dt-bindings: describe the PMU module of the QCA6390 package

On Wed, Jun 05, 2024 at 11:13:04AM +0200, Bartosz Golaszewski wrote:
> On Tue, Jun 4, 2024 at 7:30 PM Bjorn Helgaas <[email protected]> wrote:

> > LDO? Again below, but maybe this is obvious to everybody.

> Yes, this is an acceptable abbreviation to use, it's all over the
> bindings and regulator drivers.

Vastly more people are going to understand LDO than would be able to
expand the acronym.


Attachments:
(No filename) (413.00 B)
signature.asc (499.00 B)
Download all attachments