2024-01-17 17:43:04

by Markus Elfring

[permalink] [raw]
Subject: [PATCH 0/2] versatile clock: Adjustments for two function implementations

From: Markus Elfring <[email protected]>
Date: Wed, 17 Jan 2024 18:30:08 +0100

A few update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Return directly after a failed kasprintf() call in of_syscon_icst_setup()
Use common error handling code in icst_clk_setup()

drivers/clk/versatile/clk-icst.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)

--
2.43.0



2024-01-17 17:44:03

by Markus Elfring

[permalink] [raw]
Subject: [PATCH 2/2] clk: versatile: clk-icst: Use common error handling code in icst_clk_setup()

From: Markus Elfring <[email protected]>
Date: Wed, 17 Jan 2024 18:18:25 +0100

Add a jump target so that a bit of exception handling can be better reused
in an if branch of this function.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/clk/versatile/clk-icst.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-icst.c
index c4cf50a48972..9957dc9b8941 100644
--- a/drivers/clk/versatile/clk-icst.c
+++ b/drivers/clk/versatile/clk-icst.c
@@ -351,8 +351,8 @@ struct clk *icst_clk_setup(struct device *dev,

pclone = kmemdup(desc->params, sizeof(*pclone), GFP_KERNEL);
if (!pclone) {
- kfree(icst);
- return ERR_PTR(-ENOMEM);
+ clk = ERR_PTR(-ENOMEM);
+ goto free_icst;
}

init.name = name;
@@ -370,6 +370,7 @@ struct clk *icst_clk_setup(struct device *dev,
clk = clk_register(dev, &icst->hw);
if (IS_ERR(clk)) {
kfree(pclone);
+free_icst:
kfree(icst);
}

--
2.43.0