2013-05-06 09:16:50

by Schemmel Hans-Christoph

Subject: [PATCH] NET DRIVER: Added support for Cinterion's PLxx WWAN Interface

/drivers/net/usb/qmi_wwan.c: Added support for Cinterion's PLxx WWAN Interface by adding QMI_FIXED_INTF with Cinterion's Vendor ID as well as Product ID and WWAN Interface Number.

Signed-off-by: Hans-Christoph Schemmel <[email protected]>
---
patch is against linux-3.9
--- linux-3.9/drivers/net/usb/qmi_wwan.c.orig 2013-05-06 08:10:11.170034451 +0200
+++ linux-3.9/drivers/net/usb/qmi_wwan.c 2013-05-06 08:58:00.800264179 +0200
@@ -569,6 +569,7 @@ static const struct usb_device_id produc
{QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
{QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
+ {QMI_FIXED_INTF(0x1e2d, 0x12d1, 4)}, /* Cinterion PLxx */

/* 4. Gobi 1000 devices */
{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */

2013-05-06 12:07:22

by Bjørn Mork

Subject: Re: [PATCH] NET DRIVER: Added support for Cinterion's PLxx WWAN Interface

Schemmel Hans-Christoph <[email protected]> writes:

> /drivers/net/usb/qmi_wwan.c: Added support for Cinterion's PLxx WWAN Interface by adding QMI_FIXED_INTF with Cinterion's Vendor ID as well as Product ID and WWAN Interface Number.
>
> Signed-off-by: Hans-Christoph Schemmel <[email protected]>
> ---
> patch is against linux-3.9
> --- linux-3.9/drivers/net/usb/qmi_wwan.c.orig 2013-05-06 08:10:11.170034451 +0200
> +++ linux-3.9/drivers/net/usb/qmi_wwan.c 2013-05-06 08:58:00.800264179 +0200
> @@ -569,6 +569,7 @@ static const struct usb_device_id produc
> {QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
> {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
> {QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
> + {QMI_FIXED_INTF(0x1e2d, 0x12d1, 4)}, /* Cinterion PLxx */
>
> /* 4. Gobi 1000 devices */
> {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */


Looks good. Thanks.

Acked-by: Bjørn Mork <[email protected]>

2013-05-06 14:26:48

by David Miller

Subject: Re: [PATCH] NET DRIVER: Added support for Cinterion's PLxx WWAN Interface

From: Schemmel Hans-Christoph <[email protected]>
Date: Mon, 6 May 2013 11:16:46 +0200

> /drivers/net/usb/qmi_wwan.c: Added support for Cinterion's PLxx WWAN Interface by adding QMI_FIXED_INTF with Cinterion's Vendor ID as well as Product ID and WWAN Interface Number.
>
> Signed-off-by: Hans-Christoph Schemmel <[email protected]>

The Subject needs to use lowercase letters for the "prefix: " bit
coming after "[PATCH]" and use a more appropropate area indication.

"qmi_wwan: " would have been more appropriate.

Also, properly text format your commit messages so that lines are no longer
than 80 columns.

Just because it looks like it's properly formatted on your computer screen
doesn't mean it is.