2022-07-09 02:31:07

by Randy Dunlap

Subject: [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning

RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL.
Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so
quieten this kconfig warning:

WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE
Depends on [n]: !XIP_KERNEL [=y]
Selected by [y]:
- RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y]

Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Wei Fu <[email protected]>
Cc: Liu Shaohua <[email protected]>
Cc: Guo Ren <[email protected]>
Cc: Heiko Stuebner <[email protected]>
Cc: Paul Walmsley <[email protected]>
Cc: Palmer Dabbelt <[email protected]>
Cc: Albert Ou <[email protected]>
Cc: [email protected]
---
arch/riscv/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -362,6 +362,7 @@ config RISCV_ISA_C
config RISCV_ISA_SVPBMT
bool "SVPBMT extension support"
depends on 64BIT && MMU
+ depends on !XIP_KERNEL
select RISCV_ALTERNATIVE
default y
help

2022-07-20 04:15:01

by Guo Ren

Subject: Re: [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning

Reviewed-by: Guo Ren <[email protected]>

On Sat, Jul 9, 2022 at 9:49 AM Randy Dunlap <[email protected]> wrote:
>
> RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL.
> Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so
> quieten this kconfig warning:
>
> WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE
> Depends on [n]: !XIP_KERNEL [=y]
> Selected by [y]:
> - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y]
>
> Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Wei Fu <[email protected]>
> Cc: Liu Shaohua <[email protected]>
> Cc: Guo Ren <[email protected]>
> Cc: Heiko Stuebner <[email protected]>
> Cc: Paul Walmsley <[email protected]>
> Cc: Palmer Dabbelt <[email protected]>
> Cc: Albert Ou <[email protected]>
> Cc: [email protected]
> ---
> arch/riscv/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -362,6 +362,7 @@ config RISCV_ISA_C
> config RISCV_ISA_SVPBMT
> bool "SVPBMT extension support"
> depends on 64BIT && MMU
> + depends on !XIP_KERNEL
> select RISCV_ALTERNATIVE
> default y
> help



--
Best Regards
Guo Ren

2022-07-20 09:17:25

by Heiko Stuebner

Subject: Re: [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning

Am Samstag, 9. Juli 2022, 03:49:29 CEST schrieb Randy Dunlap:
> RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL.
> Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so
> quieten this kconfig warning:
>
> WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE
> Depends on [n]: !XIP_KERNEL [=y]
> Selected by [y]:
> - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y]
>
> Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Wei Fu <[email protected]>
> Cc: Liu Shaohua <[email protected]>
> Cc: Guo Ren <[email protected]>
> Cc: Heiko Stuebner <[email protected]>
> Cc: Paul Walmsley <[email protected]>
> Cc: Palmer Dabbelt <[email protected]>
> Cc: Albert Ou <[email protected]>
> Cc: [email protected]

Reviewed-by: Heiko Stuebner <[email protected]>

2022-09-13 12:11:48

by Heiko Stuebner

Subject: Re: [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning

Hi Palmer,

Am Samstag, 9. Juli 2022, 03:49:29 CEST schrieb Randy Dunlap:
> RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL.
> Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so
> quieten this kconfig warning:
>
> WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE
> Depends on [n]: !XIP_KERNEL [=y]
> Selected by [y]:
> - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y]
>
> Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")
> Signed-off-by: Randy Dunlap <[email protected]>

I think this should also be applied as fix?

Thanks
Heiko


> Cc: Wei Fu <[email protected]>
> Cc: Liu Shaohua <[email protected]>
> Cc: Guo Ren <[email protected]>
> Cc: Heiko Stuebner <[email protected]>
> Cc: Paul Walmsley <[email protected]>
> Cc: Palmer Dabbelt <[email protected]>
> Cc: Albert Ou <[email protected]>
> Cc: [email protected]
> ---
> arch/riscv/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -362,6 +362,7 @@ config RISCV_ISA_C
> config RISCV_ISA_SVPBMT
> bool "SVPBMT extension support"
> depends on 64BIT && MMU
> + depends on !XIP_KERNEL
> select RISCV_ALTERNATIVE
> default y
> help
>

2022-09-15 18:52:54

by Palmer Dabbelt

Subject: Re: [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning

On Tue, 13 Sep 2022 05:00:08 PDT (-0700), [email protected] wrote:
> Hi Palmer,
>
> Am Samstag, 9. Juli 2022, 03:49:29 CEST schrieb Randy Dunlap:
>> RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL.
>> Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so
>> quieten this kconfig warning:
>>
>> WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE
>> Depends on [n]: !XIP_KERNEL [=y]
>> Selected by [y]:
>> - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y]
>>
>> Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")
>> Signed-off-by: Randy Dunlap <[email protected]>
>
> I think this should also be applied as fix?

Thanks, the original seems to have gotten lost somewhere but I've picked
this up from lore.

>
> Thanks
> Heiko
>
>
>> Cc: Wei Fu <[email protected]>
>> Cc: Liu Shaohua <[email protected]>
>> Cc: Guo Ren <[email protected]>
>> Cc: Heiko Stuebner <[email protected]>
>> Cc: Paul Walmsley <[email protected]>
>> Cc: Palmer Dabbelt <[email protected]>
>> Cc: Albert Ou <[email protected]>
>> Cc: [email protected]
>> ---
>> arch/riscv/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- a/arch/riscv/Kconfig
>> +++ b/arch/riscv/Kconfig
>> @@ -362,6 +362,7 @@ config RISCV_ISA_C
>> config RISCV_ISA_SVPBMT
>> bool "SVPBMT extension support"
>> depends on 64BIT && MMU
>> + depends on !XIP_KERNEL
>> select RISCV_ALTERNATIVE
>> default y
>> help
>>

2022-09-15 18:52:58

by Palmer Dabbelt

Subject: Re: [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning

On Tue, 13 Sep 2022 05:00:08 PDT (-0700), [email protected] wrote:
> Hi Palmer,
>
> Am Samstag, 9. Juli 2022, 03:49:29 CEST schrieb Randy Dunlap:
>> RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL.
>> Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so
>> quieten this kconfig warning:
>>
>> WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE
>> Depends on [n]: !XIP_KERNEL [=y]
>> Selected by [y]:
>> - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y]
>>
>> Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")
>> Signed-off-by: Randy Dunlap <[email protected]>
>
> I think this should also be applied as fix?
>
> Thanks
> Heiko
>
>
>> Cc: Wei Fu <[email protected]>
>> Cc: Liu Shaohua <[email protected]>
>> Cc: Guo Ren <[email protected]>
>> Cc: Heiko Stuebner <[email protected]>
>> Cc: Paul Walmsley <[email protected]>
>> Cc: Palmer Dabbelt <[email protected]>
>> Cc: Albert Ou <[email protected]>
>> Cc: [email protected]
>> ---
>> arch/riscv/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- a/arch/riscv/Kconfig
>> +++ b/arch/riscv/Kconfig
>> @@ -362,6 +362,7 @@ config RISCV_ISA_C
>> config RISCV_ISA_SVPBMT
>> bool "SVPBMT extension support"
>> depends on 64BIT && MMU
>> + depends on !XIP_KERNEL
>> select RISCV_ALTERNATIVE
>> default y
>> help
>>

Thanks, this is on fixes.