2005-01-15 02:16:23

by Gaston, Jason D

[permalink] [raw]
Subject: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1

This patch adds the ICH7 AC'97 DID the the intel8x0.c AC'97 audio driver. ?This patch was build against 2.6.11-rc1.
If acceptable, please apply.

Thanks,

Jason Gaston

Signed-off-by: ?Jason Gaston <[email protected]>

--- linux-2.6.11-rc1/sound/pci/intel8x0.c.orig 2005-01-14 09:50:21.832749040 -0800
+++ linux-2.6.11-rc1/sound/pci/intel8x0.c 2005-01-14 09:55:44.626676904 -0800
@@ -53,6 +53,7 @@
"{Intel,82801DB-ICH4},"
"{Intel,ICH5},"
"{Intel,ICH6},"
+ "{Intel,ICH7},"
"{Intel,6300ESB},"
"{Intel,MX440},"
"{SiS,SI7012},"
@@ -120,6 +121,9 @@
#ifndef PCI_DEVICE_ID_INTEL_ICH6_3
#define PCI_DEVICE_ID_INTEL_ICH6_3 0x266e
#endif
+#ifndef PCI_DEVICE_ID_INTEL_ICH7_20
+#define PCI_DEVICE_ID_INTEL_ICH7_20 0x27de
+#endif
#ifndef PCI_DEVICE_ID_SI_7012
#define PCI_DEVICE_ID_SI_7012 0x7012
#endif
@@ -438,6 +442,7 @@
{ 0x8086, 0x24d5, PCI_ANY_ID, PCI_ANY_ID, 0, 0, DEVICE_INTEL_ICH4 }, /* ICH5 */
{ 0x8086, 0x25a6, PCI_ANY_ID, PCI_ANY_ID, 0, 0, DEVICE_INTEL_ICH4 }, /* ESB */
{ 0x8086, 0x266e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, DEVICE_INTEL_ICH4 }, /* ICH6 */
+ { 0x8086, 0x27de, PCI_ANY_ID, PCI_ANY_ID, 0, 0, DEVICE_INTEL_ICH4 }, /* ICH7 */
{ 0x8086, 0x7195, PCI_ANY_ID, PCI_ANY_ID, 0, 0, DEVICE_INTEL }, /* 440MX */
{ 0x1039, 0x7012, PCI_ANY_ID, PCI_ANY_ID, 0, 0, DEVICE_SIS }, /* SI7012 */
{ 0x10de, 0x01b1, PCI_ANY_ID, PCI_ANY_ID, 0, 0, DEVICE_NFORCE }, /* NFORCE */
@@ -2685,6 +2690,7 @@
{ PCI_DEVICE_ID_INTEL_ICH5, "Intel ICH5" },
{ PCI_DEVICE_ID_INTEL_ESB_5, "Intel 6300ESB" },
{ PCI_DEVICE_ID_INTEL_ICH6_3, "Intel ICH6" },
+ { PCI_DEVICE_ID_INTEL_ICH7_20, "Intel ICH7" },
{ PCI_DEVICE_ID_SI_7012, "SiS SI7012" },
{ PCI_DEVICE_ID_NVIDIA_MCP_AUDIO, "NVidia nForce" },
{ PCI_DEVICE_ID_NVIDIA_MCP2_AUDIO, "NVidia nForce2" },


2005-01-17 11:31:19

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1

At Fri, 14 Jan 2005 11:21:34 -0800,
Jason Gaston wrote:
>
> This patch adds the ICH7 AC'97 DID the the intel8x0.c AC'97 audio driver. ?This patch was build against 2.6.11-rc1.
> If acceptable, please apply.
>
> Thanks,
>
> Jason Gaston
>
> Signed-off-by: ?Jason Gaston <[email protected]>

Thanks, I applied the patch to ALSA tree.

Does ICH7 have an ac97 modem, too?
If so, we miss the DID in the modem driver, too.
(Well, the entry for ICH6 is also missing. Anyone can confirm such a
device?)


Takashi

2005-01-17 17:38:50

by Gaston, Jason D

[permalink] [raw]
Subject: RE: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1

ICH6 and ICH7 both have AC'97 modem DID's.

ICH6 AC'97 modem DID = 266d
ICH7 AC'97 modem DID = 27dd

Would you like me to create a patch adding both?

Thanks,

Jason



>-----Original Message-----
>From: Takashi Iwai [mailto:[email protected]]
>Sent: Monday, January 17, 2005 3:31 AM
>To: Gaston, Jason D
>Cc: [email protected]; [email protected]
>Subject: Re: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1
>
>At Fri, 14 Jan 2005 11:21:34 -0800,
>Jason Gaston wrote:
>>
>> This patch adds the ICH7 AC'97 DID the the intel8x0.c AC'97 audio driver.
>?This patch was build against 2.6.11-rc1.
>> If acceptable, please apply.
>>
>> Thanks,
>>
>> Jason Gaston
>>
>> Signed-off-by: ?Jason Gaston <[email protected]>
>
>Thanks, I applied the patch to ALSA tree.
>
>Does ICH7 have an ac97 modem, too?
>If so, we miss the DID in the modem driver, too.
>(Well, the entry for ICH6 is also missing. Anyone can confirm such a
> device?)
>
>
>Takashi

2005-01-18 09:11:43

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1

At Mon, 17 Jan 2005 09:37:17 -0800,
Gaston, Jason D wrote:
>
> ICH6 and ICH7 both have AC'97 modem DID's.
>
> ICH6 AC'97 modem DID = 266d
> ICH7 AC'97 modem DID = 27dd
>
> Would you like me to create a patch adding both?

Not necessary, the patch would be easy to me, too :)

But, I'd like to confirm that the driver really works on these
chipsets before adding the IDs.


thanks,

Takashi

> Thanks,
>
> Jason
>
>
>
> >-----Original Message-----
> >From: Takashi Iwai [mailto:[email protected]]
> >Sent: Monday, January 17, 2005 3:31 AM
> >To: Gaston, Jason D
> >Cc: [email protected]; [email protected]
> >Subject: Re: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1
> >
> >At Fri, 14 Jan 2005 11:21:34 -0800,
> >Jason Gaston wrote:
> >>
> >> This patch adds the ICH7 AC'97 DID the the intel8x0.c AC'97 audio driver.
> >?This patch was build against 2.6.11-rc1.
> >> If acceptable, please apply.
> >>
> >> Thanks,
> >>
> >> Jason Gaston
> >>
> >> Signed-off-by: ?Jason Gaston <[email protected]>
> >
> >Thanks, I applied the patch to ALSA tree.
> >
> >Does ICH7 have an ac97 modem, too?
> >If so, we miss the DID in the modem driver, too.
> >(Well, the entry for ICH6 is also missing. Anyone can confirm such a
> > device?)
> >
> >
> >Takashi
>

2005-01-18 18:18:19

by Gaston, Jason D

[permalink] [raw]
Subject: RE: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1

I have never had an opportunity to test AC'97 modems on ICH6 or ICH7.

Sorry,

Jason


>-----Original Message-----
>From: Takashi Iwai [mailto:[email protected]]
>Sent: Tuesday, January 18, 2005 1:12 AM
>To: Gaston, Jason D
>Cc: [email protected]; [email protected]
>Subject: Re: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1
>
>At Mon, 17 Jan 2005 09:37:17 -0800,
>Gaston, Jason D wrote:
>>
>> ICH6 and ICH7 both have AC'97 modem DID's.
>>
>> ICH6 AC'97 modem DID = 266d
>> ICH7 AC'97 modem DID = 27dd
>>
>> Would you like me to create a patch adding both?
>
>Not necessary, the patch would be easy to me, too :)
>
>But, I'd like to confirm that the driver really works on these
>chipsets before adding the IDs.
>
>
>thanks,
>
>Takashi
>
>> Thanks,
>>
>> Jason
>>
>>
>>
>> >-----Original Message-----
>> >From: Takashi Iwai [mailto:[email protected]]
>> >Sent: Monday, January 17, 2005 3:31 AM
>> >To: Gaston, Jason D
>> >Cc: [email protected]; [email protected]
>> >Subject: Re: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1
>> >
>> >At Fri, 14 Jan 2005 11:21:34 -0800,
>> >Jason Gaston wrote:
>> >>
>> >> This patch adds the ICH7 AC'97 DID the the intel8x0.c AC'97 audio
>driver.
>> >?This patch was build against 2.6.11-rc1.
>> >> If acceptable, please apply.
>> >>
>> >> Thanks,
>> >>
>> >> Jason Gaston
>> >>
>> >> Signed-off-by: ?Jason Gaston <[email protected]>
>> >
>> >Thanks, I applied the patch to ALSA tree.
>> >
>> >Does ICH7 have an ac97 modem, too?
>> >If so, we miss the DID in the modem driver, too.
>> >(Well, the entry for ICH6 is also missing. Anyone can confirm such a
>> > device?)
>> >
>> >
>> >Takashi
>>