2015-02-05 13:16:42

by Lad, Prabhakar

Subject: [PATCH] usb: gadget: function/uvc_v4l2.c: fix sparse warnings

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warnings:

uvc_v4l2.c:264:29: warning: symbol 'uvc_v4l2_ioctl_ops' was not declared. Should it be static?
uvc_v4l2.c:355:29: warning: symbol 'uvc_v4l2_fops' was not declared. Should it be static?

Signed-off-by: Lad, Prabhakar <[email protected]>
---
drivers/usb/gadget/function/uvc_v4l2.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/function/uvc_v4l2.c b/drivers/usb/gadget/function/uvc_v4l2.c
index 5aad7fe..8b818fd 100644
--- a/drivers/usb/gadget/function/uvc_v4l2.c
+++ b/drivers/usb/gadget/function/uvc_v4l2.c
@@ -27,6 +27,7 @@
#include "uvc.h"
#include "uvc_queue.h"
#include "uvc_video.h"
+#include "uvc_v4l2.h"

/* --------------------------------------------------------------------------
* Requests handling
--
1.9.1

2015-02-05 15:05:40

by Laurent Pinchart

Subject: Re: [PATCH] usb: gadget: function/uvc_v4l2.c: fix sparse warnings

Hi Prabhakar,

Thank you for the patch.

On Thursday 05 February 2015 13:16:26 Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <[email protected]>
>
> this patch fixes following sparse warnings:
>
> uvc_v4l2.c:264:29: warning: symbol 'uvc_v4l2_ioctl_ops' was not declared.
> Should it be static? uvc_v4l2.c:355:29: warning: symbol 'uvc_v4l2_fops' was
> not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <[email protected]>

Acked-by: Laurent Pinchart <[email protected]>

Felipe, could you please take this in your tree ?

> ---
> drivers/usb/gadget/function/uvc_v4l2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/function/uvc_v4l2.c
> b/drivers/usb/gadget/function/uvc_v4l2.c index 5aad7fe..8b818fd 100644
> --- a/drivers/usb/gadget/function/uvc_v4l2.c
> +++ b/drivers/usb/gadget/function/uvc_v4l2.c
> @@ -27,6 +27,7 @@
> #include "uvc.h"
> #include "uvc_queue.h"
> #include "uvc_video.h"
> +#include "uvc_v4l2.h"
>
> /* -------------------------------------------------------------------------
> * Requests handling

--
Regards,

Laurent Pinchart