2021-10-18 03:34:27

by Nicolas Frattaroli

Subject: [PATCH 2/4] ASoC: dt-bindings: rockchip: i2s-tdm: Drop rockchip,cru property

This property was only needed for a driver hack, which we can
remove. Since the bindings were not in any kernel release yet, we
are able to just drop the property instead of silently accepting
and ignoring it.

Signed-off-by: Nicolas Frattaroli <[email protected]>
---
.../bindings/sound/rockchip,i2s-tdm.yaml | 16 ----------------
1 file changed, 16 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
index ce3e18b50230..6a7c004bef17 100644
--- a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
+++ b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
@@ -82,12 +82,6 @@ properties:
- tx-m
- rx-m

- rockchip,cru:
- $ref: /schemas/types.yaml#/definitions/phandle
- description:
- The phandle of the cru.
- Required if neither trcm-sync-tx-only nor trcm-sync-rx-only are specified.
-
rockchip,grf:
$ref: /schemas/types.yaml#/definitions/phandle
description:
@@ -144,15 +138,6 @@ required:
- rockchip,grf
- "#sound-dai-cells"

-allOf:
- - if:
- properties:
- rockchip,trcm-sync-tx-only: false
- rockchip,trcm-sync-rx-only: false
- then:
- required:
- - rockchip,cru
-
additionalProperties: false

examples:
@@ -177,7 +162,6 @@ examples:
resets = <&cru SRST_M_I2S1_8CH_TX>, <&cru SRST_M_I2S1_8CH_RX>;
reset-names = "tx-m", "rx-m";
rockchip,trcm-sync-tx-only;
- rockchip,cru = <&cru>;
rockchip,grf = <&grf>;
#sound-dai-cells = <0>;
pinctrl-names = "default";
--
2.33.1

2021-10-18 03:38:01

by Heiko Stuebner

Subject: Re: [PATCH 2/4] ASoC: dt-bindings: rockchip: i2s-tdm: Drop rockchip,cru property

Am Samstag, 16. Oktober 2021, 12:53:51 CEST schrieb Nicolas Frattaroli:
> This property was only needed for a driver hack, which we can
> remove. Since the bindings were not in any kernel release yet, we
> are able to just drop the property instead of silently accepting
> and ignoring it.
>
> Signed-off-by: Nicolas Frattaroli <[email protected]>

Reviewed-by: Heiko Stuebner <[email protected]>

Thanks for doing that change :-)
Heiko


> ---
> .../bindings/sound/rockchip,i2s-tdm.yaml | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
> index ce3e18b50230..6a7c004bef17 100644
> --- a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
> +++ b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
> @@ -82,12 +82,6 @@ properties:
> - tx-m
> - rx-m
>
> - rockchip,cru:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description:
> - The phandle of the cru.
> - Required if neither trcm-sync-tx-only nor trcm-sync-rx-only are specified.
> -
> rockchip,grf:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> @@ -144,15 +138,6 @@ required:
> - rockchip,grf
> - "#sound-dai-cells"
>
> -allOf:
> - - if:
> - properties:
> - rockchip,trcm-sync-tx-only: false
> - rockchip,trcm-sync-rx-only: false
> - then:
> - required:
> - - rockchip,cru
> -
> additionalProperties: false
>
> examples:
> @@ -177,7 +162,6 @@ examples:
> resets = <&cru SRST_M_I2S1_8CH_TX>, <&cru SRST_M_I2S1_8CH_RX>;
> reset-names = "tx-m", "rx-m";
> rockchip,trcm-sync-tx-only;
> - rockchip,cru = <&cru>;
> rockchip,grf = <&grf>;
> #sound-dai-cells = <0>;
> pinctrl-names = "default";
>