CHARGER_MAX8997 fails to compile without CONFIG_EXTCON. There are stubs
already present for *extcon_*_notifier() but are missing for the _all()
variant.
Add *extcon_*_notifier_all() stubs for !CONFIG_EXTCON.
Fixes: f384989e88d44 ("power: supply: max8997_charger: Set CHARGER current limit")
Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
---
include/linux/extcon.h | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/include/linux/extcon.h b/include/linux/extcon.h
index fd183fb9c20f7..8246307f9ed38 100644
--- a/include/linux/extcon.h
+++ b/include/linux/extcon.h
@@ -276,6 +276,30 @@ static inline struct extcon_dev *extcon_get_extcon_dev(const char *extcon_name)
return ERR_PTR(-ENODEV);
}
+static inline int extcon_register_notifier_all(struct extcon_dev *edev,
+ struct notifier_block *nb)
+{
+ return -EINVAL;
+}
+
+static inline int extcon_unregister_notifier_all(struct extcon_dev *edev,
+ struct notifier_block *nb)
+{
+ return 0;
+}
+
+static inline int devm_extcon_register_notifier_all(struct device *dev,
+ struct extcon_dev *edev,
+ struct notifier_block *nb)
+{
+ return -EINVAL;
+}
+
+static inline void devm_extcon_unregister_notifier_all(struct device *dev,
+ struct extcon_dev *edev,
+ struct notifier_block *nb)
+{ }
+
static inline struct extcon_dev *extcon_find_edev_by_node(struct device_node *node)
{
return ERR_PTR(-ENODEV);
--
2.30.2
On Fri, 12 Mar 2021 at 15:10, Sebastian Andrzej Siewior
<[email protected]> wrote:
>
> CHARGER_MAX8997 fails to compile without CONFIG_EXTCON. There are stubs
> already present for *extcon_*_notifier() but are missing for the _all()
> variant.
>
> Add *extcon_*_notifier_all() stubs for !CONFIG_EXTCON.
>
> Fixes: f384989e88d44 ("power: supply: max8997_charger: Set CHARGER current limit")
> Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
> ---
> include/linux/extcon.h | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
Thanks for the patch.
Fix was sent some time ago and is already in extcon tree:
https://lore.kernel.org/lkml/[email protected]/
Did you base your work on next?
Best regards,
Krzysztof
On 2021-03-12 15:45:48 [+0100], Krzysztof Kozlowski wrote:
> Did you base your work on next?
no, -rc2.
> Best regards,
> Krzysztof
Sebastian
On 12/03/2021 15:53, Sebastian Andrzej Siewior wrote:
> On 2021-03-12 15:45:48 [+0100], Krzysztof Kozlowski wrote:
>> Did you base your work on next?
>
> no, -rc2.
Yeah, it missed the merge window...
Best regards,
Krzysztof
On 2021-03-12 15:53:53 [+0100], Krzysztof Kozlowski wrote:
> Yeah, it missed the merge window...
Could you please send it for -rc3?
> Best regards,
> Krzysztof
Sebastian
On 12/03/2021 15:55, Sebastian Andrzej Siewior wrote:
> On 2021-03-12 15:53:53 [+0100], Krzysztof Kozlowski wrote:
>> Yeah, it missed the merge window...
>
> Could you please send it for -rc3?
I meant, the pull missed the merge window. Chanwoo already confirmed he
will be sending it for rc3.
https://lore.kernel.org/lkml/[email protected]/
Best regards,
Krzysztof