2020-04-25 08:53:18

by Chen Tao

Subject: [PATCH] net: phy: bcm54140: Make a bunch of functions static

Fix the following warning:

drivers/net/phy/bcm54140.c:663:5: warning:
symbol 'bcm54140_did_interrupt' was not declared. Should it be static?
drivers/net/phy/bcm54140.c:672:5: warning:
symbol 'bcm54140_ack_intr' was not declared. Should it be static?
drivers/net/phy/bcm54140.c:684:5: warning:
symbol 'bcm54140_config_intr' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: ChenTao <[email protected]>
---
drivers/net/phy/bcm54140.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/phy/bcm54140.c b/drivers/net/phy/bcm54140.c
index 7341f0126cc4..c009ac2856a5 100644
--- a/drivers/net/phy/bcm54140.c
+++ b/drivers/net/phy/bcm54140.c
@@ -660,7 +660,7 @@ static int bcm54140_config_init(struct phy_device *phydev)
BCM54140_RDB_C_PWR_ISOLATE, 0);
}

-int bcm54140_did_interrupt(struct phy_device *phydev)
+static int bcm54140_did_interrupt(struct phy_device *phydev)
{
int ret;

@@ -669,7 +669,7 @@ int bcm54140_did_interrupt(struct phy_device *phydev)
return (ret < 0) ? 0 : ret;
}

-int bcm54140_ack_intr(struct phy_device *phydev)
+static int bcm54140_ack_intr(struct phy_device *phydev)
{
int reg;

@@ -681,7 +681,7 @@ int bcm54140_ack_intr(struct phy_device *phydev)
return 0;
}

-int bcm54140_config_intr(struct phy_device *phydev)
+static int bcm54140_config_intr(struct phy_device *phydev)
{
struct bcm54140_priv *priv = phydev->priv;
static const u16 port_to_imr_bit[] = {
--
2.22.0

2020-04-27 18:17:20

by David Miller

Subject: Re: [PATCH] net: phy: bcm54140: Make a bunch of functions static

From: ChenTao <[email protected]>
Date: Sat, 25 Apr 2020 16:49:44 +0800

> Fix the following warning:
>
> drivers/net/phy/bcm54140.c:663:5: warning:
> symbol 'bcm54140_did_interrupt' was not declared. Should it be static?
> drivers/net/phy/bcm54140.c:672:5: warning:
> symbol 'bcm54140_ack_intr' was not declared. Should it be static?
> drivers/net/phy/bcm54140.c:684:5: warning:
> symbol 'bcm54140_config_intr' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: ChenTao <[email protected]>

The appropriate mailing list for networking changes is [email protected]
so please resubmit this there.

Thank you.

2020-04-28 01:43:58

by Chen Tao

Subject: Re: [PATCH] net: phy: bcm54140: Make a bunch of functions static

Thanks a lot, i will resubmit the patch.

On 2020/4/28 2:14, David Miller wrote:
> From: ChenTao <[email protected]>
> Date: Sat, 25 Apr 2020 16:49:44 +0800
>
>> Fix the following warning:
>>
>> drivers/net/phy/bcm54140.c:663:5: warning:
>> symbol 'bcm54140_did_interrupt' was not declared. Should it be static?
>> drivers/net/phy/bcm54140.c:672:5: warning:
>> symbol 'bcm54140_ack_intr' was not declared. Should it be static?
>> drivers/net/phy/bcm54140.c:684:5: warning:
>> symbol 'bcm54140_config_intr' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: ChenTao <[email protected]>
> The appropriate mailing list for networking changes is [email protected]
> so please resubmit this there.
>
> Thank you.
> .