2024-06-01 15:40:58

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] dt-bindings: display: panel: Add KD101NE3-40TI support

On 01/06/2024 10:45, Zhaoxiong Lv wrote:
> Create a new dt-scheam for the kd101ne3-40ti.
> The bias IC of this kindisplay-kd101ne3 panel is placed
> on the panel side, so when the panel is powered on,
> there is no need to control AVDD and AVEE in the driver.

> +
> + reg:
> + description: the virtual channel number of a DSI peripheral
> +
> + pp3300-supply:
> + description: core voltage supply
> +
> +required:
> + - compatible
> + - reg
> + - pp3300-supply
> + - enable-gpios
> + - backlight
> + - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + panel: panel@0 {
> + compatible = "kingdisplay,kd101ne3-40ti";
> + reg = <0>;
> + enable-gpios = <&pio 98 0>;

Please use the define, not drop the header.

Best regards,
Krzysztof