2021-01-13 22:45:29

by Ian Rogers

Subject: [PATCH 1/2] bpf, libbpf: Avoid unused function warning on bpf_tail_call_static

Add inline to __always_inline making it match the linux/compiler.h.
Adding this avoids an unused function warning on bpf_tail_call_static
when compining with -Wall.

Signed-off-by: Ian Rogers <[email protected]>
---
tools/lib/bpf/bpf_helpers.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/bpf/bpf_helpers.h b/tools/lib/bpf/bpf_helpers.h
index 72b251110c4d..ae6c975e0b87 100644
--- a/tools/lib/bpf/bpf_helpers.h
+++ b/tools/lib/bpf/bpf_helpers.h
@@ -30,7 +30,7 @@
#define SEC(NAME) __attribute__((section(NAME), used))

#ifndef __always_inline
-#define __always_inline __attribute__((always_inline))
+#define __always_inline inline __attribute__((always_inline))
#endif
#ifndef __noinline
#define __noinline __attribute__((noinline))
--
2.30.0.284.gd98b1dd5eaa7-goog

2021-01-14 01:48:36

by Yonghong Song

Subject: Re: [PATCH 1/2] bpf, libbpf: Avoid unused function warning on bpf_tail_call_static

On 1/13/21 2:36 PM, Ian Rogers wrote:
> Add inline to __always_inline making it match the linux/compiler.h.
> Adding this avoids an unused function warning on bpf_tail_call_static
> when compining with -Wall.
>
> Signed-off-by: Ian Rogers <[email protected]>

Acked-by: Yonghong Song <[email protected]>

2021-01-14 02:05:57

by Ian Rogers

Subject: [PATCH 2/2] tools/bpftool: Add -Wall when building BPF programs

No additional warnings are generated by enabling this, but having it
enabled will help avoid regressions.

Signed-off-by: Ian Rogers <[email protected]>
---
tools/bpf/bpftool/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
index f897cb5fb12d..45ac2f9e0aa9 100644
--- a/tools/bpf/bpftool/Makefile
+++ b/tools/bpf/bpftool/Makefile
@@ -166,7 +166,7 @@ $(OUTPUT)%.bpf.o: skeleton/%.bpf.c $(OUTPUT)vmlinux.h $(LIBBPF)
-I$(srctree)/tools/include/uapi/ \
-I$(LIBBPF_PATH) \
-I$(srctree)/tools/lib \
- -g -O2 -target bpf -c $< -o $@ && $(LLVM_STRIP) -g $@
+ -g -O2 -Wall -target bpf -c $< -o $@ && $(LLVM_STRIP) -g $@

$(OUTPUT)%.skel.h: $(OUTPUT)%.bpf.o $(BPFTOOL_BOOTSTRAP)
$(QUIET_GEN)$(BPFTOOL_BOOTSTRAP) gen skeleton $< > $@
--
2.30.0.284.gd98b1dd5eaa7-goog

2021-01-14 02:43:37

by Yonghong Song

Subject: Re: [PATCH 2/2] tools/bpftool: Add -Wall when building BPF programs

On 1/13/21 2:36 PM, Ian Rogers wrote:
> No additional warnings are generated by enabling this, but having it
> enabled will help avoid regressions.
>
> Signed-off-by: Ian Rogers <[email protected]>

Acked-by: Yonghong Song <[email protected]>

2021-01-14 03:22:15

by patchwork-bot+netdevbpf

Subject: Re: [PATCH 1/2] bpf, libbpf: Avoid unused function warning on bpf_tail_call_static

Hello:

This series was applied to bpf/bpf-next.git (refs/heads/master):

On Wed, 13 Jan 2021 14:36:08 -0800 you wrote:
> Add inline to __always_inline making it match the linux/compiler.h.
> Adding this avoids an unused function warning on bpf_tail_call_static
> when compining with -Wall.
>
> Signed-off-by: Ian Rogers <[email protected]>
> ---
> tools/lib/bpf/bpf_helpers.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [1/2] bpf, libbpf: Avoid unused function warning on bpf_tail_call_static
https://git.kernel.org/bpf/bpf-next/c/ce5a518e9de5
- [2/2] tools/bpftool: Add -Wall when building BPF programs
https://git.kernel.org/bpf/bpf-next/c/bade5c554f1a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html