2023-07-14 05:15:15

by chenqingyun001

[permalink] [raw]
Subject: [PATCH] KVM: arm64:#include <linux/cacheflush.h> instead of <asm/cacheflush.h>

<linux/cacheflush.h> is a generic header file,
while <asm/cacheflush.h> is an x86
architecture-specific header file

Signed-off-by: Qingyun Chen <[email protected]>
---
arch/arm64/lib/uaccess_flushcache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/lib/uaccess_flushcache.c
b/arch/arm64/lib/uaccess_flushcache.c
index 7510d1a23124..cf8052f6e091 100644
--- a/arch/arm64/lib/uaccess_flushcache.c
+++ b/arch/arm64/lib/uaccess_flushcache.c
@@ -5,7 +5,7 @@

#include <linux/uaccess.h>
#include <asm/barrier.h>
-#include <asm/cacheflush.h>
+#include <linux/cacheflush.h>

void memcpy_flushcache(void *dst, const void *src, size_t cnt)
{


2023-07-14 08:33:48

by Will Deacon

[permalink] [raw]
Subject: Re: [PATCH] KVM: arm64:#include <linux/cacheflush.h> instead of <asm/cacheflush.h>

On Fri, Jul 14, 2023 at 01:09:10PM +0800, [email protected] wrote:
> <linux/cacheflush.h> is a generic header file,
> while <asm/cacheflush.h> is an x86
> architecture-specific header file

wut?

Will

> Signed-off-by: Qingyun Chen <[email protected]>
> ---
> arch/arm64/lib/uaccess_flushcache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/lib/uaccess_flushcache.c
> b/arch/arm64/lib/uaccess_flushcache.c
> index 7510d1a23124..cf8052f6e091 100644
> --- a/arch/arm64/lib/uaccess_flushcache.c
> +++ b/arch/arm64/lib/uaccess_flushcache.c
> @@ -5,7 +5,7 @@
>
> #include <linux/uaccess.h>
> #include <asm/barrier.h>
> -#include <asm/cacheflush.h>
> +#include <linux/cacheflush.h>
>
> void memcpy_flushcache(void *dst, const void *src, size_t cnt)
> {