2019-06-10 16:20:32

by Yue Haibing

Subject: [PATCH net-next] tcp: Make tcp_fastopen_alloc_ctx static

Fix sparse warning:

net/ipv4/tcp_fastopen.c:75:29: warning:
symbol 'tcp_fastopen_alloc_ctx' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
net/ipv4/tcp_fastopen.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/ipv4/tcp_fastopen.c b/net/ipv4/tcp_fastopen.c
index 8e15804..7d19fa4 100644
--- a/net/ipv4/tcp_fastopen.c
+++ b/net/ipv4/tcp_fastopen.c
@@ -72,9 +72,9 @@ void tcp_fastopen_ctx_destroy(struct net *net)
call_rcu(&ctxt->rcu, tcp_fastopen_ctx_free);
}

-struct tcp_fastopen_context *tcp_fastopen_alloc_ctx(void *primary_key,
- void *backup_key,
- unsigned int len)
+static struct tcp_fastopen_context *tcp_fastopen_alloc_ctx(void *primary_key,
+ void *backup_key,
+ unsigned int len)
{
struct tcp_fastopen_context *new_ctx;
void *key = primary_key;
--
2.7.4

2019-06-10 16:46:26

by Jason Baron

Subject: Re: [PATCH net-next] tcp: Make tcp_fastopen_alloc_ctx static

On 6/10/19 11:19 AM, YueHaibing wrote:
> Fix sparse warning:
>
> net/ipv4/tcp_fastopen.c:75:29: warning:
> symbol 'tcp_fastopen_alloc_ctx' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> net/ipv4/tcp_fastopen.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/ipv4/tcp_fastopen.c b/net/ipv4/tcp_fastopen.c
> index 8e15804..7d19fa4 100644
> --- a/net/ipv4/tcp_fastopen.c
> +++ b/net/ipv4/tcp_fastopen.c
> @@ -72,9 +72,9 @@ void tcp_fastopen_ctx_destroy(struct net *net)
> call_rcu(&ctxt->rcu, tcp_fastopen_ctx_free);
> }
>
> -struct tcp_fastopen_context *tcp_fastopen_alloc_ctx(void *primary_key,
> - void *backup_key,
> - unsigned int len)
> +static struct tcp_fastopen_context *tcp_fastopen_alloc_ctx(void *primary_key,
> + void *backup_key,
> + unsigned int len)
> {
> struct tcp_fastopen_context *new_ctx;
> void *key = primary_key;
>

Thanks for fixing.
Acked-by: Jason Baron <[email protected]>