2019-11-05 16:03:16

by Chuhong Yuan

Subject: [PATCH v2] rtc: brcmstb-waketimer: add missed clk_disable_unprepare

This driver forgets to disable and unprepare clock when remove.
Add a call to clk_disable_unprepare to fix it.

Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
Signed-off-by: Chuhong Yuan <[email protected]>
---
Changes in v2:
- Remove the check for timer->clk and add fixes tag.

drivers/rtc/rtc-brcmstb-waketimer.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/rtc/rtc-brcmstb-waketimer.c b/drivers/rtc/rtc-brcmstb-waketimer.c
index 3e9800f9878a..82d2ab0b3e9c 100644
--- a/drivers/rtc/rtc-brcmstb-waketimer.c
+++ b/drivers/rtc/rtc-brcmstb-waketimer.c
@@ -277,6 +277,7 @@ static int brcmstb_waketmr_remove(struct platform_device *pdev)
struct brcmstb_waketmr *timer = dev_get_drvdata(&pdev->dev);

unregister_reboot_notifier(&timer->reboot_notifier);
+ clk_disable_unprepare(timer->clk);

return 0;
}
--
2.23.0

2019-11-05 17:05:35

by Florian Fainelli

Subject: Re: [PATCH v2] rtc: brcmstb-waketimer: add missed clk_disable_unprepare

On 11/5/19 8:00 AM, Chuhong Yuan wrote:
> This driver forgets to disable and unprepare clock when remove.
> Add a call to clk_disable_unprepare to fix it.
>
> Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
> Signed-off-by: Chuhong Yuan <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2019-11-05 17:21:19

by Alexandre Belloni

Subject: Re: [PATCH v2] rtc: brcmstb-waketimer: add missed clk_disable_unprepare

On 06/11/2019 00:00:43+0800, Chuhong Yuan wrote:
> This driver forgets to disable and unprepare clock when remove.
> Add a call to clk_disable_unprepare to fix it.
>
> Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
> Signed-off-by: Chuhong Yuan <[email protected]>
> ---
> Changes in v2:
> - Remove the check for timer->clk and add fixes tag.
>
> drivers/rtc/rtc-brcmstb-waketimer.c | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com