On Monday 20 October 2014 15:25:32 Michal Simek wrote:
> Enable generic allocator by default because it is used by OCMC driver.
>
> Signed-off-by: Michal Simek <[email protected]>
Why doesn't the driver select this then?
Arnd
>
> diff --git a/arch/arm/mach-zynq/Kconfig b/arch/arm/mach-zynq/Kconfig
> index aaa5162c1509..d447adefd397 100644
> --- a/arch/arm/mach-zynq/Kconfig
> +++ b/arch/arm/mach-zynq/Kconfig
> @@ -5,6 +5,7 @@ config ARCH_ZYNQ
> select ARM_GIC
> select ARM_GLOBAL_TIMER if !CPU_FREQ
> select CADENCE_TTC_TIMER
> + select GENERIC_ALLOCATOR
> select HAVE_ARM_SCU if SMP
> select HAVE_ARM_TWD if SMP
> select ICST
>
On Monday 20 October 2014 15:25:31 Michal Simek wrote:
> include/soc/zynq/ is the right location for this header
> to be able to share information from this header with other
> drivers which require it.
>
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> Changes in v2:
> - Update pm.c added in 3.17 too - Soren pointed on it
>
> arch/arm/mach-zynq/common.c | 2 +-
> arch/arm/mach-zynq/hotplug.c | 14 --------------
> arch/arm/mach-zynq/platsmp.c | 2 +-
> arch/arm/mach-zynq/pm.c | 2 +-
> arch/arm/mach-zynq/slcr.c | 2 +-
> {arch/arm/mach-zynq => include/soc/zynq}/common.h | 0
> 6 files changed, 4 insertions(+), 18 deletions(-)
> delete mode 100644 arch/arm/mach-zynq/hotplug.c
> rename {arch/arm/mach-zynq => include/soc/zynq}/common.h (100%)
>
NAK
Most (if not all) of that header should not be visible to drivers.
If you need to share some symbols, make a proper header file for those,
not one called 'common.h'.
Arnd
On 10/20/2014 03:34 PM, Arnd Bergmann wrote:
> On Monday 20 October 2014 15:25:32 Michal Simek wrote:
>> Enable generic allocator by default because it is used by OCMC driver.
>>
>> Signed-off-by: Michal Simek <[email protected]>
>
>
> Why doesn't the driver select this then?
It can but currently OCM driver is enabled by default without Kconfig entry.
Appreciate your input on driver itself.
http://lists.openwall.net/linux-kernel/2014/10/06/196
Thanks,
Michal
On 10/20/2014 03:36 PM, Arnd Bergmann wrote:
> On Monday 20 October 2014 15:25:31 Michal Simek wrote:
>> include/soc/zynq/ is the right location for this header
>> to be able to share information from this header with other
>> drivers which require it.
>>
>> Signed-off-by: Michal Simek <[email protected]>
>> ---
>>
>> Changes in v2:
>> - Update pm.c added in 3.17 too - Soren pointed on it
>>
>> arch/arm/mach-zynq/common.c | 2 +-
>> arch/arm/mach-zynq/hotplug.c | 14 --------------
>> arch/arm/mach-zynq/platsmp.c | 2 +-
>> arch/arm/mach-zynq/pm.c | 2 +-
>> arch/arm/mach-zynq/slcr.c | 2 +-
>> {arch/arm/mach-zynq => include/soc/zynq}/common.h | 0
>> 6 files changed, 4 insertions(+), 18 deletions(-)
>> delete mode 100644 arch/arm/mach-zynq/hotplug.c
>> rename {arch/arm/mach-zynq => include/soc/zynq}/common.h (100%)
>>
>
> NAK
>
> Most (if not all) of that header should not be visible to drivers.
> If you need to share some symbols, make a proper header file for those,
> not one called 'common.h'.
Ok. I will split it to more files - no problem to do it.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform