2023-05-10 08:27:29

by Maksim Kiselev

Subject: [PATCH v5 1/5] dt-bindings: spi: sun6i: add DT bindings for Allwinner R329/D1/R528/T113s SPI

Listed above Allwinner SoCs has two SPI controllers. First is the regular
SPI controller and the second one has additional functionality for
MIPI-DBI Type C.

Add compatible strings for these controllers

Signed-off-by: Maksim Kiselev <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/spi/allwinner,sun6i-a31-spi.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
index de36c6a34a0f..fa5260eca531 100644
--- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
@@ -19,6 +19,7 @@ properties:

compatible:
oneOf:
+ - const: allwinner,sun50i-r329-spi
- const: allwinner,sun6i-a31-spi
- const: allwinner,sun8i-h3-spi
- items:
@@ -28,6 +29,15 @@ properties:
- allwinner,sun50i-h616-spi
- allwinner,suniv-f1c100s-spi
- const: allwinner,sun8i-h3-spi
+ - items:
+ - enum:
+ - allwinner,sun20i-d1-spi
+ - allwinner,sun50i-r329-spi-dbi
+ - const: allwinner,sun50i-r329-spi
+ - items:
+ - const: allwinner,sun20i-d1-spi-dbi
+ - const: allwinner,sun50i-r329-spi-dbi
+ - const: allwinner,sun50i-r329-spi

reg:
maxItems: 1
--
2.39.2

2023-05-10 10:44:58

by Andre Przywara

Subject: Re: [PATCH v5 1/5] dt-bindings: spi: sun6i: add DT bindings for Allwinner R329/D1/R528/T113s SPI

On Wed, 10 May 2023 11:11:08 +0300
Maksim Kiselev <[email protected]> wrote:

Hi,

> Listed above Allwinner SoCs has two SPI controllers. First is the regular
> SPI controller and the second one has additional functionality for
> MIPI-DBI Type C.
>
> Add compatible strings for these controllers
>
> Signed-off-by: Maksim Kiselev <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>

thanks for the changes, looks good now and dt-validate passes.

Reviewed-by: Andre Przywara <[email protected]>

Cheers,
Andre

> ---
> .../bindings/spi/allwinner,sun6i-a31-spi.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> index de36c6a34a0f..fa5260eca531 100644
> --- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> @@ -19,6 +19,7 @@ properties:
>
> compatible:
> oneOf:
> + - const: allwinner,sun50i-r329-spi
> - const: allwinner,sun6i-a31-spi
> - const: allwinner,sun8i-h3-spi
> - items:
> @@ -28,6 +29,15 @@ properties:
> - allwinner,sun50i-h616-spi
> - allwinner,suniv-f1c100s-spi
> - const: allwinner,sun8i-h3-spi
> + - items:
> + - enum:
> + - allwinner,sun20i-d1-spi
> + - allwinner,sun50i-r329-spi-dbi
> + - const: allwinner,sun50i-r329-spi
> + - items:
> + - const: allwinner,sun20i-d1-spi-dbi
> + - const: allwinner,sun50i-r329-spi-dbi
> + - const: allwinner,sun50i-r329-spi
>
> reg:
> maxItems: 1

2023-05-11 16:42:53

by Jernej Škrabec

Subject: Re: [PATCH v5 1/5] dt-bindings: spi: sun6i: add DT bindings for Allwinner R329/D1/R528/T113s SPI

Dne sreda, 10. maj 2023 ob 10:11:08 CEST je Maksim Kiselev napisal(a):
> Listed above Allwinner SoCs has two SPI controllers. First is the regular
> SPI controller and the second one has additional functionality for
> MIPI-DBI Type C.
>
> Add compatible strings for these controllers
>
> Signed-off-by: Maksim Kiselev <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Jernej Skrabec <[email protected]>

Best regards,
Jernej