2021-12-09 13:55:21

by Neil Armstrong

Subject: Re: [PATCH] dt-bindings: arm: amlogic: add S4 based AQ222 bindings

+cc [email protected] [email protected]

On 08/12/2021 10:33, xianwei.zhao wrote:
> Add bindings for the new Amlogic S4 SoC family,
> and the compatible for the Amlogic S4 Based AQ222 board.
>
> S4 is an application processor designed for hybrid OTT/IP Set To
> Box(STB) and high-end media box applications, with quad core Cortex-A35.
>
> Signed-off-by: xianwei.zhao <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 36081734f720..63037ebdd7bf 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -183,6 +183,12 @@ properties:
> - amlogic,ad401
> - const: amlogic,a1
>
> + - description: Boards with the Amlogic Meson S4 AQ222 SoC
> + items:
> + - enum:
> + - amlogic,aq222
> + - const: amlogic,s4
> +
> additionalProperties: true
>
> ...
>
> base-commit: a3ebdcc8fb3d94de390e58ad3da6161826a58a87
>

2021-12-09 13:58:21

by Neil Armstrong

Subject: Re: [PATCH] dt-bindings: arm: amlogic: add S4 based AQ222 bindings

On 09/12/2021 14:55, Neil Armstrong wrote:
> +cc [email protected] [email protected]
>
> On 08/12/2021 10:33, xianwei.zhao wrote:
>> Add bindings for the new Amlogic S4 SoC family,
>> and the compatible for the Amlogic S4 Based AQ222 board.

What's the SoC commercial name ? s805x2 ? and the board model ? AQ222 and the family ? S4 ?

>>
>> S4 is an application processor designed for hybrid OTT/IP Set To
>> Box(STB) and high-end media box applications, with quad core Cortex-A35.
>>
>> Signed-off-by: xianwei.zhao <[email protected]>
>> ---
>> Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> index 36081734f720..63037ebdd7bf 100644
>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> @@ -183,6 +183,12 @@ properties:
>> - amlogic,ad401
>> - const: amlogic,a1
>>
>> + - description: Boards with the Amlogic Meson S4 AQ222 SoC

So it should be:
- description: Boards with the Amlogic Meson S4 S805X2 SoC

>> + items:
>> + - enum:
>> + - amlogic,aq222
>> + - const: amlogic,s4
>> +
>> additionalProperties: true
>>
>> ...
>>
>> base-commit: a3ebdcc8fb3d94de390e58ad3da6161826a58a87
>>
>

Neil