2022-12-07 07:34:01

by Yang Yang

[permalink] [raw]
Subject: [PATCH linux-next] docs: proc.rst: add softnet_stat

From: Yang Yang <[email protected]>

Softnet_stat shows statistics of struct softnet_data of online CPUs.
Struct softnet_data manages incoming and output packets on
per-CPU queues. Notice that fastroute and cpu_collision in
softnet_stat are obsoleted, their value is always 0.

Signed-off-by: Yang Yang <[email protected]>
Reviewed-by: xu xin <[email protected]>
Reviewed-by: Zhang Yunkai <[email protected]>
---
Documentation/filesystems/proc.rst | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
index e224b6d5b642..9d5fd9424e8b 100644
--- a/Documentation/filesystems/proc.rst
+++ b/Documentation/filesystems/proc.rst
@@ -1284,6 +1284,7 @@ support this. Table 1-9 lists the files and their meaning.
rt_cache Routing cache
snmp SNMP data
sockstat Socket statistics
+ softnet_stat Per-CPU incoming packets queues statistics of online CPUs
tcp TCP sockets
udp UDP sockets
unix UNIX domain sockets
--
2.15.2


2022-12-07 10:24:54

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH linux-next] docs: proc.rst: add softnet_stat

On 12/7/22 13:23, [email protected] wrote:
> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> index e224b6d5b642..9d5fd9424e8b 100644
> --- a/Documentation/filesystems/proc.rst
> +++ b/Documentation/filesystems/proc.rst
> @@ -1284,6 +1284,7 @@ support this. Table 1-9 lists the files and their meaning.
> rt_cache Routing cache
> snmp SNMP data
> sockstat Socket statistics
> + softnet_stat Per-CPU incoming packets queues statistics of online CPUs
> tcp TCP sockets
> udp UDP sockets
> unix UNIX domain sockets

Add softnet_stat to what table? I have to read the actual documentation
and found that you mean /proc/net table. Please mention that in patch
subject.

Regardless, this patch is from ZTE people, for which they have a
reputation for ignoring critical code reviews and "atypical" email
setup that needs to be fixed (try searching for `tc:"zte.com.cn" AND
f:"[email protected]"` on LKML for details). If you can
receive this email, please hit "Reply all", "Group Reply" or similar.
Remember don't top-post, reply inline with appropriate context instead.

Thanks.

--
An old man doll... just what I always wanted! - Clara

2022-12-07 10:37:31

by Yang Yang

[permalink] [raw]
Subject: Re: [PATCH linux-next] docs: proc.rst: add softnet_stat

On 12/7/22 17:10, [email protected] wrote:
> Add softnet_stat to what table? I have to read the actual documentation
> and found that you mean /proc/net table. Please mention that in patch
> subject.

OK, I will add this to subject.

> Regardless, this patch is from ZTE people, for which they have a
> reputation for ignoring critical code reviews and "atypical" email
> setup that needs to be fixed

Really sorry for that, We will try to avoid this.

Thanks.