Hi all,
After merging the pm tree, today's linux-next build (x86_64 allnoconfig)
failed like this:
fs/libfs.c: In function 'memory_read_from_io_buffer':
fs/libfs.c:829:2: error: implicit declaration of function 'memcpy_fromio' [-Werror=implicit-function-declaration]
829 | memcpy_fromio(to, from + pos, count);
| ^~~~~~~~~~~~~
Caused by commit
08c07cefb304 ("ACPI: sysfs: copy ACPI data using io memory copying")
Missing include of linux/io.h?
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
Hi all,
On Tue, 17 Mar 2020 18:52:52 +1100 Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the pm tree, today's linux-next build (x86_64 allnoconfig)
> failed like this:
>
> fs/libfs.c: In function 'memory_read_from_io_buffer':
> fs/libfs.c:829:2: error: implicit declaration of function 'memcpy_fromio' [-Werror=implicit-function-declaration]
> 829 | memcpy_fromio(to, from + pos, count);
> | ^~~~~~~~~~~~~
>
> Caused by commit
>
> 08c07cefb304 ("ACPI: sysfs: copy ACPI data using io memory copying")
>
> Missing include of linux/io.h?
>
> I have reverted that commit for today.
This was fixed today (by including linux/ioh), but the latest update to
the pm tree has removed that include again.
--
Cheers,
Stephen Rothwell
On 18/03/2020 11:44, Stephen Rothwell wrote:
> Hi all,
>
> On Tue, 17 Mar 2020 18:52:52 +1100 Stephen Rothwell <[email protected]> wrote:
>>
>> Hi all,
>>
>> After merging the pm tree, today's linux-next build (x86_64 allnoconfig)
>> failed like this:
>>
>> fs/libfs.c: In function 'memory_read_from_io_buffer':
>> fs/libfs.c:829:2: error: implicit declaration of function 'memcpy_fromio' [-Werror=implicit-function-declaration]
>> 829 | memcpy_fromio(to, from + pos, count);
>> | ^~~~~~~~~~~~~
>>
>> Caused by commit
>>
>> 08c07cefb304 ("ACPI: sysfs: copy ACPI data using io memory copying")
>>
>> Missing include of linux/io.h?
>>
>> I have reverted that commit for today.
>
> This was fixed today (by including linux/ioh), but the latest update to
> the pm tree has removed that include again.
>
Hopefully it won't be reverted from linux-next?
Colin
Hi Colin,
On Wed, 18 Mar 2020 11:52:00 +0000 Colin Ian King <[email protected]> wrote:
>
> > This was fixed today (by including linux/ioh), but the latest update to
> > the pm tree has removed that include again.
> >
> Hopefully it won't be reverted from linux-next?
Linux-next just contains what its constituent trees contain each day ...
--
Cheers,
Stephen Rothwell
Hi Stephen,
On Wed, 18 Mar 2020 23:18:37 +1100 Stephen Rothwell <[email protected]> wrote:
>
> Hi Colin,
>
> On Wed, 18 Mar 2020 11:52:00 +0000 Colin Ian King <[email protected]> wrote:
> >
> > > This was fixed today (by including linux/ioh), but the latest update to
> > > the pm tree has removed that include again.
> > >
> > Hopefully it won't be reverted from linux-next?
>
> Linux-next just contains what its constituent trees contain each day ...
I have had to revert commit
08c07cefb304 ("ACPI: sysfs: copy ACPI data using io memory copying")
again.
--
Cheers,
Stephen Rothwell
On Thursday, March 19, 2020 6:42:59 AM CET Stephen Rothwell wrote:
>
> --Sig_/Pgc07lYg4LlrlRQi0UWj2DK
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
>
> Hi Stephen,
>
> On Wed, 18 Mar 2020 23:18:37 +1100 Stephen Rothwell <[email protected]> =
> wrote:
> >
> > Hi Colin,
> >=20
> > On Wed, 18 Mar 2020 11:52:00 +0000 Colin Ian King <[email protected]=
> om> wrote:
> > > =20
> > > > This was fixed today (by including linux/ioh), but the latest update =
> to
> > > > the pm tree has removed that include again.
> > > > =20
> > > Hopefully it won't be reverted from linux-next? =20
> >=20
> > Linux-next just contains what its constituent trees contain each day ...
>
> I have had to revert commit
>
> 08c07cefb304 ("ACPI: sysfs: copy ACPI data using io memory copying")
Dropped from linux-pm now and sorry for the breakage.
Colin, please resend this one when all of the dependencies are in place in the
Linus' tree.
Thanks!