2013-04-15 07:09:53

by Viresh Kumar

Subject: [PATCH] cpufreq: cpu0: Put cpu parent node after using it

Parent node must be put after using it to balance its usage count. This was
missing in cpufreq-cpu0 driver. Fix it.

Signed-off-by: Viresh Kumar <[email protected]>
---
drivers/cpufreq/cpufreq-cpu0.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
index 31282fc..3ab8294 100644
--- a/drivers/cpufreq/cpufreq-cpu0.c
+++ b/drivers/cpufreq/cpufreq-cpu0.c
@@ -257,6 +257,7 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev)
}

of_node_put(np);
+ of_node_put(parent);
return 0;

out_free_table:
--
1.7.12.rc2.18.g61b472e

2013-04-16 08:40:37

by Shawn Guo

Subject: Re: [PATCH] cpufreq: cpu0: Put cpu parent node after using it

On Mon, Apr 15, 2013 at 12:39:37PM +0530, Viresh Kumar wrote:
> Parent node must be put after using it to balance its usage count. This was
> missing in cpufreq-cpu0 driver. Fix it.
>
> Signed-off-by: Viresh Kumar <[email protected]>

Acked-by: Shawn Guo <[email protected]>

> ---
> drivers/cpufreq/cpufreq-cpu0.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
> index 31282fc..3ab8294 100644
> --- a/drivers/cpufreq/cpufreq-cpu0.c
> +++ b/drivers/cpufreq/cpufreq-cpu0.c
> @@ -257,6 +257,7 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev)
> }
>
> of_node_put(np);
> + of_node_put(parent);
> return 0;
>
> out_free_table:
> --
> 1.7.12.rc2.18.g61b472e
>

2013-04-21 23:23:30

by Rafael J. Wysocki

Subject: Re: [PATCH] cpufreq: cpu0: Put cpu parent node after using it

On Tuesday, April 16, 2013 04:40:15 PM Shawn Guo wrote:
> On Mon, Apr 15, 2013 at 12:39:37PM +0530, Viresh Kumar wrote:
> > Parent node must be put after using it to balance its usage count. This was
> > missing in cpufreq-cpu0 driver. Fix it.
> >
> > Signed-off-by: Viresh Kumar <[email protected]>
>
> Acked-by: Shawn Guo <[email protected]>

Applied.

Thanks,
Rafael


> > ---
> > drivers/cpufreq/cpufreq-cpu0.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
> > index 31282fc..3ab8294 100644
> > --- a/drivers/cpufreq/cpufreq-cpu0.c
> > +++ b/drivers/cpufreq/cpufreq-cpu0.c
> > @@ -257,6 +257,7 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev)
> > }
> >
> > of_node_put(np);
> > + of_node_put(parent);
> > return 0;
> >
> > out_free_table:
>
> --
> To unsubscribe from this list: send the line "unsubscribe cpufreq" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.