2022-06-13 03:54:12

by Yang Li

Subject: [PATCH -next] scsi: target: iscsi: Fix NULL pointer dereference in iscsi_conn_auth_required()

Fix following coccicheck error:
./drivers/target/iscsi/iscsi_target_nego.c:831:13-26: ERROR: se_nacl is
NULL but dereferenced.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/target/iscsi/iscsi_target_nego.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
index 9ce35a59962b..fb93a1173954 100644
--- a/drivers/target/iscsi/iscsi_target_nego.c
+++ b/drivers/target/iscsi/iscsi_target_nego.c
@@ -827,8 +827,7 @@ static bool iscsi_conn_auth_required(struct iscsit_conn *conn)
*/
se_nacl = conn->sess->se_sess->se_node_acl;
if (!se_nacl) {
- pr_debug("Unknown ACL %s is trying to connect\n",
- se_nacl->initiatorname);
+ pr_debug("Unknown ACL is trying to connect\n");
return true;
}

--
2.20.1.7.g153144c

2022-06-13 18:58:36

by Mike Christie

Subject: Re: [PATCH -next] scsi: target: iscsi: Fix NULL pointer dereference in iscsi_conn_auth_required()

On 6/12/22 8:43 PM, Yang Li wrote:
> Fix following coccicheck error:
> ./drivers/target/iscsi/iscsi_target_nego.c:831:13-26: ERROR: se_nacl is
> NULL but dereferenced.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

This was just added in Martin's 5.20 tree in:

a75fcb0912a549c6c1da8395f33271ce06e84acd

scsi: target: iscsi: Extract auth functions

Do we need a Fixes or should the original patch be fixed?

Patch looks ok to me, so if we just add it:

Reviewed-by: Mike Christie <[email protected]>

> ---
> drivers/target/iscsi/iscsi_target_nego.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
> index 9ce35a59962b..fb93a1173954 100644
> --- a/drivers/target/iscsi/iscsi_target_nego.c
> +++ b/drivers/target/iscsi/iscsi_target_nego.c
> @@ -827,8 +827,7 @@ static bool iscsi_conn_auth_required(struct iscsit_conn *conn)
> */
> se_nacl = conn->sess->se_sess->se_node_acl;
> if (!se_nacl) {
> - pr_debug("Unknown ACL %s is trying to connect\n",
> - se_nacl->initiatorname);
> + pr_debug("Unknown ACL is trying to connect\n");
> return true;
> }
>

2022-06-14 03:07:25

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: target: iscsi: Fix NULL pointer dereference in iscsi_conn_auth_required()

Yang,

> Fix following coccicheck error:
> ./drivers/target/iscsi/iscsi_target_nego.c:831:13-26: ERROR: se_nacl is
> NULL but dereferenced.

Applied to 5.20/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2022-06-17 02:40:05

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: target: iscsi: Fix NULL pointer dereference in iscsi_conn_auth_required()

On Mon, 13 Jun 2022 09:43:21 +0800, Yang Li wrote:

> Fix following coccicheck error:
> ./drivers/target/iscsi/iscsi_target_nego.c:831:13-26: ERROR: se_nacl is
> NULL but dereferenced.
>
>

Applied to 5.20/scsi-queue, thanks!

[1/1] scsi: target: iscsi: Fix NULL pointer dereference in iscsi_conn_auth_required()
https://git.kernel.org/mkp/scsi/c/35bf020bd8ab

--
Martin K. Petersen Oracle Linux Engineering