2024-05-10 08:38:34

by Chen Ni

Subject: [PATCH] soc: qcom: pmic_glink: Handle the return value of pmic_glink_init

As platform_driver_register() and register_rpmsg_driver() can return
error numbers, it should be better to check the return value and deal
with the exception.

Signed-off-by: Chen Ni <[email protected]>
---
drivers/soc/qcom/pmic_glink.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c
index 40fb09d69014..8534a9692c45 100644
--- a/drivers/soc/qcom/pmic_glink.c
+++ b/drivers/soc/qcom/pmic_glink.c
@@ -369,8 +369,17 @@ static struct platform_driver pmic_glink_driver = {

static int pmic_glink_init(void)
{
- platform_driver_register(&pmic_glink_driver);
- register_rpmsg_driver(&pmic_glink_rpmsg_driver);
+ int ret;
+
+ ret = platform_driver_register(&pmic_glink_driver);
+ if (ret < 0)
+ return ret;
+
+ ret = register_rpmsg_driver(&pmic_glink_rpmsg_driver);
+ if (ret < 0) {
+ platform_driver_unregister(&pmic_glink_driver);
+ return ret;
+ }

return 0;
}
--
2.25.1

2024-05-10 10:16:56

by Bryan O'Donoghue

Subject: Re: [PATCH] soc: qcom: pmic_glink: Handle the return value of pmic_glink_init

On 10/05/2024 09:31, Chen Ni wrote:
> As platform_driver_register() and register_rpmsg_driver() can return
> error numbers, it should be better to check the return value and deal
> with the exception.
>
> Signed-off-by: Chen Ni <[email protected]>
> ---
> drivers/soc/qcom/pmic_glink.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c
> index 40fb09d69014..8534a9692c45 100644
> --- a/drivers/soc/qcom/pmic_glink.c
> +++ b/drivers/soc/qcom/pmic_glink.c
> @@ -369,8 +369,17 @@ static struct platform_driver pmic_glink_driver = {
>
> static int pmic_glink_init(void)
> {
> - platform_driver_register(&pmic_glink_driver);
> - register_rpmsg_driver(&pmic_glink_rpmsg_driver);
> + int ret;
> +
> + ret = platform_driver_register(&pmic_glink_driver);
> + if (ret < 0)
> + return ret;
> +
> + ret = register_rpmsg_driver(&pmic_glink_rpmsg_driver);
> + if (ret < 0) {
> + platform_driver_unregister(&pmic_glink_driver);
> + return ret;
> + }
>
> return 0;
> }

Please add a Fixes tag

Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK
driver")

Then add

Reviewed-by: Bryan O'Donoghue <[email protected]>

---
bod

2024-05-28 03:37:43

by Bjorn Andersson

Subject: Re: [PATCH] soc: qcom: pmic_glink: Handle the return value of pmic_glink_init

On Fri, 10 May 2024 16:31:56 +0800, Chen Ni wrote:
> As platform_driver_register() and register_rpmsg_driver() can return
> error numbers, it should be better to check the return value and deal
> with the exception.
>
>

Applied, thanks!

[1/1] soc: qcom: pmic_glink: Handle the return value of pmic_glink_init
commit: 0780c836673b25f5aad306630afcb1172d694cb4

Best regards,
--
Bjorn Andersson <[email protected]>