cpqphp.h: In function `cpq_get_latch_status':
cpqphp.h:698: warning: concatenation of string literals with
__FUNCTION__ is deprecated
cpqphp.h: In function `wait_for_ctrl_irq':
cpqphp.h:736: warning: concatenation of string literals with
__FUNCTION__ is deprecated
cpqphp.h:746: warning: concatenation of string literals with
__FUNCTION__ is deprecated
cpqphp_nvram.c:163: warning: concatenation of string literals with
__FUNCTION__ is deprecated
cpqphp_nvram.c:179:17: missing terminating " character
cpqphp_nvram.c: In function `access_EV':
cpqphp_nvram.c:180: parse error before "xorl"
cpqphp_nvram.c:184:28: missing terminating " character
People, please don't do things like:
spin_lock_irqsave(&int15_lock, flags);
__asm__ (
"xorl %%ebx,%%ebx
xorl %%edx,%%edx
pushf
push %%cs
cli
call *%6"
Patches keep going in to fix this.
Please do something like:
spin_lock_irqsave(&int15_lock, flags);
__asm__ (
"xorl %%ebx,%%ebx \n"
"xorl %%edx,%%edx \n"
"pushf \n"
"push %%cs \n"
"cli \n"
"call *%6 \n"
i2o_core.c:3393:75: missing terminating " character
printk(KERN_WARNING "i2o: Could not quiesce %s." "
Verify setup on next system power up.\n", c->name);
Please write it like:
printk(KERN_WARNING "i2o: Could not quiesce %s."
"Verify setup on next system power up.\n", c->name);
-d
Hi,
On Mon, 10 Jun 2002, David Ford wrote:
> People, please don't do things like:
>
> [bad use of doublequotes]
>
> Patches keep going in to fix this.
>
> [good use of doublequotes]
The same applies to 2.5. Can someone write a perl script that treats it so
anonymous that it can find these buggy places?
Index: drivers/message/i2o/i2o_core.c
===================================================================
RCS file: /var/cvs/thunder-2.5/drivers/message/i2o/i2o_core.c,v
diff -u -3 -p -r1.1 -r1.2
--- thunder-2.5/drivers/message/i2o/i2o_core.c 10 Jun 2002 15:17:07 -0000 1.1
+++ thunder-2.5/drivers/message/i2o/i2o_core.c 11 Jun 2002 00:54:24 -0000 1.2
@@ -3407,8 +3407,9 @@ static int i2o_reboot_event(struct notif
{
if(i2o_quiesce_controller(c))
{
- printk(KERN_WARNING "i2o: Could not quiesce %s." "
- Verify setup on next system power up.\n", c->name);
+ printk(KERN_WARNING "i2o: Could not quiesce %s."
+ "Verify setup on next system power up.\n",
+ c->name);
}
}
Index: drivers/hotplug/cpqphp_nvram.c
===================================================================
RCS file: /var/cvs/thunder-2.5/drivers/hotplug/cpqphp_nvram.c,v
diff -u -3 -p -r1.1 -r1.2
--- thunder-2.5/drivers/hotplug/cpqphp_nvram.c 10 Jun 2002 15:13:54 -0000 1.1
+++ thunder-2.5/drivers/hotplug/cpqphp_nvram.c 11 Jun 2002 00:54:24 -0000 1.2
@@ -176,12 +176,12 @@ static u32 access_EV (u16 operation, u8
spin_lock_irqsave(&int15_lock, flags);
__asm__ (
- "xorl %%ebx,%%ebx
- xorl %%edx,%%edx
- pushf
- push %%cs
- cli
- call *%6"
+ "xorl %%ebx,%%ebx \n"
+ "xorl %%edx,%%edx \n"
+ "pushf \n"
+ "push %%cs \n"
+ "cli \n"
+ "call *%6 \n"
: "=c" (*buf_size), "=a" (ret_val)
: "a" (op), "c" (*buf_size), "S" (ev_name),
"D" (buffer), "m" (compaq_int15_entry_point)
Regards,
Thunder
--
German attitude becoming | Thunder from the hill at ngforever
rightaway popular: |
"Get outa my way, | free inhabitant not directly
for I got a mobile phone!" | belonging anywhere
Hi,
On Mon, 10 Jun 2002, Jacob Luna Lundberg wrote:
> On Mon, 10 Jun 2002, Thunder from the hill wrote:
> > - printk(KERN_WARNING "i2o: Could not quiesce %s." "
> > - Verify setup on next system power up.\n", c->name);
> > + printk(KERN_WARNING "i2o: Could not quiesce %s."
> > + "Verify setup on next system power up.\n",
> > + c->name);
>
> Don't we lose a \n if you do that? Speaking of, is "\n" better, or " "
> I wonder... ;)
You're right, here comes the accurate version:
Index: drivers/message/i2o/i2o_core.c
===================================================================
RCS file: /var/cvs/thunder-2.5/drivers/message/i2o/i2o_core.c,v
retrieving revision 1.1
diff -u -3 -p -r1.1 i2o_core.c
--- thunder-2.5/drivers/message/i2o/i2o_core.c 10 Jun 2002 15:17:07 -0000 1.1
+++ thunder-2.5/drivers/message/i2o/i2o_core.c 11 Jun 2002 01:22:10 -0000
@@ -3407,8 +3407,9 @@ static int i2o_reboot_event(struct notif
{
if(i2o_quiesce_controller(c))
{
- printk(KERN_WARNING "i2o: Could not quiesce %s." "
- Verify setup on next system power up.\n", c->name);
+ printk(KERN_WARNING "i2o: Could not quiesce %s.\n"
+ "Verify setup on next system power up.\n",
+ c->name);
}
}
Index: drivers/hotplug/cpqphp_nvram.c
===================================================================
RCS file: /var/cvs/thunder-2.5/drivers/hotplug/cpqphp_nvram.c,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -3 -p -r1.1 -r1.2
--- thunder-2.5/drivers/hotplug/cpqphp_nvram.c 10 Jun 2002 15:13:54 -0000 1.1
+++ thunder-2.5/drivers/hotplug/cpqphp_nvram.c 11 Jun 2002 00:54:24 -0000 1.2
@@ -176,12 +176,12 @@ static u32 access_EV (u16 operation, u8
spin_lock_irqsave(&int15_lock, flags);
__asm__ (
- "xorl %%ebx,%%ebx
- xorl %%edx,%%edx
- pushf
- push %%cs
- cli
- call *%6"
+ "xorl %%ebx,%%ebx \n"
+ "xorl %%edx,%%edx \n"
+ "pushf \n"
+ "push %%cs \n"
+ "cli \n"
+ "call *%6 \n"
: "=c" (*buf_size), "=a" (ret_val)
: "a" (op), "c" (*buf_size), "S" (ev_name),
"D" (buffer), "m" (compaq_int15_entry_point)
Regards,
Thunder
--
German attitude becoming | Thunder from the hill at ngforever
rightaway popular: |
"Get outa my way, | free inhabitant not directly
for I got a mobile phone!" | belonging anywhere
My choice was to drop the \n, I don't like very short statements spread
over multiple lines especially if I'm grepping for things.
That's why I chose not to include a \n.
-d
Thunder from the hill wrote:
>Hi,
>
>On Mon, 10 Jun 2002, Jacob Luna Lundberg wrote:
>
>
>>On Mon, 10 Jun 2002, Thunder from the hill wrote:
>>
>>
>>>- printk(KERN_WARNING "i2o: Could not quiesce %s." "
>>>- Verify setup on next system power up.\n", c->name);
>>>+ printk(KERN_WARNING "i2o: Could not quiesce %s."
>>>+ "Verify setup on next system power up.\n",
>>>+ c->name);
>>>
>>>
>>Don't we lose a \n if you do that? Speaking of, is "\n" better, or " "
>>I wonder... ;)
>>
>>
>
>You're right, here comes the accurate version:
>
>
>
On Mon, Jun 10, 2002 at 06:59:36PM -0600, Thunder from the hill wrote:
> Hi,
>
> On Mon, 10 Jun 2002, David Ford wrote:
> > People, please don't do things like:
> >
> > [bad use of doublequotes]
> >
> > Patches keep going in to fix this.
> >
> > [good use of doublequotes]
>
> The same applies to 2.5. Can someone write a perl script that treats it so
> anonymous that it can find these buggy places?
And could someone actually _tell_ the maintainers of these drivers that
there is a problem? And what compiler version causes it?
This the first I've heard of this problem.
greg k-h
It's been brought up over and over the last couple of years. GCC
started warning about it quite a while ago and it's been named as a bad
form. Patches to fix various things have been submitted sporadically
for a long time as well. Future versions of GCC will mark it as an error.
David
Greg KH wrote:
>On Mon, Jun 10, 2002 at 06:59:36PM -0600, Thunder from the hill wrote:
>
>
>>Hi,
>>
>>On Mon, 10 Jun 2002, David Ford wrote:
>>
>>
>>>People, please don't do things like:
>>>
>>>[bad use of doublequotes]
>>>
>>>Patches keep going in to fix this.
>>>
>>>[good use of doublequotes]
>>>
>>>
>>The same applies to 2.5. Can someone write a perl script that treats it so
>>anonymous that it can find these buggy places?
>>
>>
>
>And could someone actually _tell_ the maintainers of these drivers that
>there is a problem? And what compiler version causes it?
>
>This the first I've heard of this problem.
>
>greg k-h
>
>