2002-09-05 21:50:55

by Andreas Steinmetz

[permalink] [raw]

Subject: 2.4.20pre5 trivial assembler warning fix for pci-pc.c

---

--- arch/i386/kernel/pci-pc.c.orig 2002-09-05 22:16:40.000000000 +0200
+++ arch/i386/kernel/pci-pc.c 2002-09-05 22:18:00.000000000 +0200
@@ -589,7 +589,7 @@
unsigned long flags;

__save_flags(flags); __cli();
- __asm__("lcall (%%edi); cld"
+ __asm__("lcall *(%%edi); cld"
: "=a" (return_code),
"=b" (address),
"=c" (length),
@@ -630,7 +630,7 @@

__save_flags(flags); __cli();
__asm__(
- "lcall (%%edi); cld\n\t"
+ "lcall *(%%edi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -675,7 +675,7 @@
unsigned short bx;
unsigned short ret;

- __asm__("lcall (%%edi); cld\n\t"
+ __asm__("lcall *(%%edi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -704,7 +704,7 @@

switch (len) {
case 1:
- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -716,7 +716,7 @@
"S" (&pci_indirect));
break;
case 2:
- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -728,7 +728,7 @@
"S" (&pci_indirect));
break;
case 4:
- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -759,7 +759,7 @@

switch (len) {
case 1:
- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -771,7 +771,7 @@
"S" (&pci_indirect));
break;
case 2:
- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -783,7 +783,7 @@
"S" (&pci_indirect));
break;
case 4:
- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -1006,7 +1006,7 @@
__asm__("push %%es\n\t"
"push %%ds\n\t"
"pop %%es\n\t"
- "lcall (%%esi); cld\n\t"
+ "lcall *(%%esi); cld\n\t"
"pop %%es\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
@@ -1039,7 +1039,7 @@
{
int ret;

- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"

---

Attachments:

pci-pc.c.diff (2.10 kB)

2002-09-05 23:20:23

by Alan

[permalink] [raw]

Subject: Re: 2.4.20pre5 trivial assembler warning fix for pci-pc.c

---

On Thu, 2002-09-05 at 21:22, Andreas Steinmetz wrote:
> trivial fix for "Warning: indirect lcall without `*'" assembler warnings
> attached.

I've always left those because there are still old binutils around that
misassemble with the "*". One for 2.5 IMHO