2002-11-04 13:31:35

by Andreas Steinmetz

[permalink] [raw]
Subject: [PATCH] 2.4.20rc1 compile fix for t128.c

--- ./drivers/scsi/t128.c.orig 2002-11-04 14:21:30.000000000 +0100
+++ ./drivers/scsi/t128.c 2002-11-04 14:21:47.000000000 +0100
@@ -145,7 +145,7 @@
static const struct signature {
const char *string;
int offset;
-} signatures[] __initdata = {
+} signatures[] = {
{"TSROM: SCSI BIOS, Version 1.12", 0x36},
};

Attachments:
t128.c.diff (319.00 B)

2002-11-04 13:55:41

by Alan

[permalink] [raw]
Subject: Re: [PATCH] 2.4.20rc1 compile fix for t128.c

On Mon, 2002-11-04 at 13:37, Andreas Steinmetz wrote:
> The attached patch fixes a section type conflict error.

Which compiler is showing this problem ?

> --- ./drivers/scsi/t128.c.orig 2002-11-04 14:21:30.000000000 +0100
> +++ ./drivers/scsi/t128.c 2002-11-04 14:21:47.000000000 +0100
> @@ -145,7 +145,7 @@
> static const struct signature {
> const char *string;
> int offset;
> -} signatures[] __initdata = {
> +} signatures[] = {
> {"TSROM: SCSI BIOS, Version 1.12", 0x36},

Far better to lose the const

2002-11-04 14:10:54

by Andreas Steinmetz

[permalink] [raw]
Subject: Re: [PATCH] 2.4.20rc1 compile fix for t128.c

[forgot to cc lkml]

Alan Cox wrote:
> On Mon, 2002-11-04 at 13:37, Andreas Steinmetz wrote:
>
>>The attached patch fixes a section type conflict error.
>
>
> Which compiler is showing this problem ?
>

gcc 3.2

>
>>--- ./drivers/scsi/t128.c.orig 2002-11-04 14:21:30.000000000 +0100
>>+++ ./drivers/scsi/t128.c 2002-11-04 14:21:47.000000000 +0100
>>@@ -145,7 +145,7 @@
>> static const struct signature {
>> const char *string;
>> int offset;
>>-} signatures[] __initdata = {
>>+} signatures[] = {
>> {"TSROM: SCSI BIOS, Version 1.12", 0x36},
>
>
> Far better to lose the const
>

any way you please.

>

--
Andreas Steinmetz
D.O.M. Datenverarbeitung GmbH