Drop a mistaken comma in the pr_info() args to prevent the
build warning.
../drivers/acpi/acpi_fpdt.c: In function 'acpi_init_fpdt':
../include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
../drivers/acpi/acpi_fpdt.c:255:4: note: in expansion of macro 'pr_info'
pr_info(FW_BUG, "Invalid subtable type %d found.\n",
Fixes: 208757d71098 ("ACPI: tables: introduce support for FPDT table")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Cc: Rafael J. Wysocki <[email protected]>
Cc: Len Brown <[email protected]>
Cc: [email protected]
Cc: Zhang Rui <[email protected]>
---
drivers/acpi/acpi_fpdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20210128.orig/drivers/acpi/acpi_fpdt.c
+++ linux-next-20210128/drivers/acpi/acpi_fpdt.c
@@ -252,7 +252,7 @@ void acpi_init_fpdt(void)
subtable->type);
break;
default:
- pr_info(FW_BUG, "Invalid subtable type %d found.\n",
+ pr_info(FW_BUG "Invalid subtable type %d found.\n",
subtable->type);
return;
}
On Thu, 2021-01-28 at 15:25 -0800, Randy Dunlap wrote:
> Drop a mistaken comma in the pr_info() args to prevent the
> build warning.
>
> ../drivers/acpi/acpi_fpdt.c: In function 'acpi_init_fpdt':
> ../include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
> ../drivers/acpi/acpi_fpdt.c:255:4: note: in expansion of macro 'pr_info'
> ????pr_info(FW_BUG, "Invalid subtable type %d found.\n",
[]
> --- linux-next-20210128.orig/drivers/acpi/acpi_fpdt.c
> +++ linux-next-20210128/drivers/acpi/acpi_fpdt.c
> @@ -252,7 +252,7 @@ void acpi_init_fpdt(void)
> ? subtable->type);
> ? break;
> ? default:
> - pr_info(FW_BUG, "Invalid subtable type %d found.\n",
> + pr_info(FW_BUG "Invalid subtable type %d found.\n",
> ? subtable->type);
Another question would be why is the pr_info when all the other
FW_BUG uses in this file are pr_err
One would think it's at least a defect of some time.
I would think it should at least be pr_notice or pr_warn
Documentation/admin-guide/kernel-parameters.txt- 1 (KERN_ALERT) action must be taken immediately
Documentation/admin-guide/kernel-parameters.txt- 2 (KERN_CRIT) critical conditions
Documentation/admin-guide/kernel-parameters.txt- 3 (KERN_ERR) error conditions
Documentation/admin-guide/kernel-parameters.txt- 4 (KERN_WARNING) warning conditions
Documentation/admin-guide/kernel-parameters.txt- 5 (KERN_NOTICE) normal but significant condition
Documentation/admin-guide/kernel-parameters.txt: 6 (KERN_INFO) informational
Documentation/admin-guide/kernel-parameters.txt- 7 (KERN_DEBUG) debug-level messages
On Thu, 2021-01-28 at 15:56 -0800, Joe Perches wrote:
> On Thu, 2021-01-28 at 15:25 -0800, Randy Dunlap wrote:
> > Drop a mistaken comma in the pr_info() args to prevent the
> > build warning.
> >
> > ../drivers/acpi/acpi_fpdt.c: In function 'acpi_init_fpdt':
> > ../include/linux/kern_levels.h:5:18: warning: too many arguments
> > for format [-Wformat-extra-args]
> > ../drivers/acpi/acpi_fpdt.c:255:4: note: in expansion of macro
> > 'pr_info'
> > pr_info(FW_BUG, "Invalid subtable type %d found.\n",
>
> []
> > --- linux-next-20210128.orig/drivers/acpi/acpi_fpdt.c
> > +++ linux-next-20210128/drivers/acpi/acpi_fpdt.c
> > @@ -252,7 +252,7 @@ void acpi_init_fpdt(void)
> > subtable->type);
> > break;
> > default:
> > - pr_info(FW_BUG, "Invalid subtable type %d
> > found.\n",
> > + pr_info(FW_BUG "Invalid subtable type %d
> > found.\n",
> > subtable->type);
>
> Another question would be why is the pr_info when all the other
> FW_BUG uses in this file are pr_err
>
Here, this FW_BUG just means an unrecognized subtable is found, and it
should not affect the other subtables that are already supported by
this driver. So that's why we didn't use pr_err.
In fact, I've just posted a V2 patch,
https://patchwork.kernel.org/project/linux-acpi/patch/[email protected]/
and I prefer to continue processing even if this FW_BUG is detected.
> One would think it's at least a defect of some time.
> I would think it should at least be pr_notice or pr_warn
I'm also okay with pr_notice/pr_warn here.
This FW_BUG should be really rare.
thanks,
rui
>
> Documentation/admin-guide/kernel
> -parameters.txt- 1
> (KERN_ALERT) action must be taken immediately
> Documentation/admin-guide/kernel
> -parameters.txt- 2
> (KERN_CRIT) critical conditions
> Documentation/admin-guide/kernel
> -parameters.txt- 3 (KERN_ERR) error
> conditions
> Documentation/admin-guide/kernel
> -parameters.txt- 4
> (KERN_WARNING) warning conditions
> Documentation/admin-guide/kernel
> -parameters.txt- 5
> (KERN_NOTICE) normal but significant condition
> Documentation/admin-guide/kernel-
> parameters.txt: 6
> (KERN_INFO) informational
> Documentation/admin-guide/kernel
> -parameters.txt- 7
> (KERN_DEBUG) debug-level messages
>
>
Hi, Randy,
Thanks for the patch, a similar patch has been posted earlier, but I
forgot to cc linux-acpi mailing list.
https://marc.info/?l=linux-next&m=161172750710666&w=2
Now given that there are a couple of fixes needed for the original
patch, I just refreshed the original patch to include all the fixes.
https://patchwork.kernel.org/project/linux-acpi/patch/[email protected]/
thanks,
rui
On Thu, 2021-01-28 at 15:25 -0800, Randy Dunlap wrote:
> Drop a mistaken comma in the pr_info() args to prevent the
> build warning.
>
> ../drivers/acpi/acpi_fpdt.c: In function 'acpi_init_fpdt':
> ../include/linux/kern_levels.h:5:18: warning: too many arguments for
> format [-Wformat-extra-args]
> ../drivers/acpi/acpi_fpdt.c:255:4: note: in expansion of macro
> 'pr_info'
> pr_info(FW_BUG, "Invalid subtable type %d found.\n",
>
> Fixes: 208757d71098 ("ACPI: tables: introduce support for FPDT
> table")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: Rafael J. Wysocki <[email protected]>
> Cc: Len Brown <[email protected]>
> Cc: [email protected]
> Cc: Zhang Rui <[email protected]>
> ---
> drivers/acpi/acpi_fpdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210128.orig/drivers/acpi/acpi_fpdt.c
> +++ linux-next-20210128/drivers/acpi/acpi_fpdt.c
> @@ -252,7 +252,7 @@ void acpi_init_fpdt(void)
> subtable->type);
> break;
> default:
> - pr_info(FW_BUG, "Invalid subtable type %d
> found.\n",
> + pr_info(FW_BUG "Invalid subtable type %d
> found.\n",
> subtable->type);
> return;
> }